Repository navigation
Conversation
|
Preview of modified files: no change to preview. |
Summary
|
Contributor
Author
|
Replaced with https://github.com/ibexa/version-comparison/pull/134 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After the changes from https://github.com/ibexa/version-comparison/pull/132 , the composer install commands fail in this repo.
Example failure:
https://github.com/ibexa/documentation-developer/actions/runs/31193936516/job/92917410245?pr=3345
The solution is to downgrade the PHPUnit dependency - from 11 to 9.6 (PHPUnit 10 requires sebastian/diff:^5.0).
This forces us to convert from PHP Attributes to PHPDoc annotations.
With these changes, the tests are running correctly and are passing.