Skip to content

IBX-11778: Updated GitHub Actions to latest versions - #3345

Merged
alongosz merged 2 commits into
5.0from
ibx-11778-update-gha-workflows
Sep 1, 2026
Merged

alongosz merged 2 commits into
5.0from
ibx-11778-update-gha-workflows

Conversation

@alongosz

@alongosz alongosz commented Aug 7, 2026

Copy link
Copy Markdown
Member
🎫 Issue IBX-11778

Related PRs:

Description:

Bumped all uses: action references in .github/workflows/ to their latest versions, and standardized runs-on: to ubuntu-26.04 (the current standard derived from the ibexa/bundle-generator ibexa-oss skeleton).

Most bumps are MAJOR version jumps (repos hadn't been touched in a while):

  • actions/checkout v3/v4 → v7
  • actions/setup-python v3/v5 → v7
  • stefanzweifel/git-auto-commit-action v4 → v7
  • DavidAnson/markdownlint-cli2-action v20 → v24
  • vale-cli/vale-action v2 → v3
  • actions/create-github-app-token v2 → v3
  • actions/upload-artifact v4 → v7
  • peter-evans/find-comment v3 → v4
  • actions/github-script v6 → v9
  • peter-evans/create-or-update-comment v4 → v5
  • actions/setup-node v4 → v7
  • peter-evans/create-pull-request v7 → v8
  • actions/cache v4 → v6

Pin styles were preserved, not changed:

  • ramsey/composer-install and marocchino/sticky-pull-request-comment are pinned to version branches (v3/v2v4/v3) in most files — kept as branch pins per that convention.
  • ramsey/composer-install in release_composer_package.yaml is SHA-pinned separately — bumped the SHA to the 4.0.0 tag, kept the SHA-pin style.
  • shivammathur/setup-php (SHA pin) and lycheeverse/lychee-action (SHA pin) were already current, no change.
  • ibexa/gh-workflows/...@main (reviewers.yaml) is a deliberate trunk-tracking pin, left untouched.

For QA:

No functional changes expected; this only bumps CI tooling versions and the runner image.

Documentation:

Review

🤖 Generated with Claude Code

@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown

Preview of modified files: no change to preview.

Comment thread .github/workflows/api_refs.yaml Dismissed
Comment thread .github/workflows/build.yaml Dismissed
Comment thread .github/workflows/build.yaml Dismissed
Comment thread .github/workflows/build.yaml Dismissed
Comment thread .github/workflows/build.yaml Dismissed
Comment thread .github/workflows/code_samples.yaml Dismissed
Comment thread .github/workflows/code_samples.yaml Dismissed
Comment thread .github/workflows/link_check.yaml Dismissed
Comment thread .github/workflows/preview_comment.yaml Dismissed
Comment thread .github/workflows/preview_comment.yaml Dismissed
@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown

Summary

Status Count
🔍 Total 750725
🔗 Unique 15057
✅ Successful 6306
⏳ Timeouts 1
🔀 Redirected 2
👻 Excluded 744418
❓ Unknown 0
🚫 Errors 0
⛔ Unsupported 0

Timeouts per input

Timeouts in site/content_management/field_types/type_and_value/index.html

Redirects per input

Redirects in site/ai/ai_actions/configure_ai_actions/index.html

Full Github Actions output

@mnocon

mnocon commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

I guess you're doing it for other repos as well, and it would make sense to have a consistent approach for all Engineering repos - we're ignoring the Use full commit SHA hash for this dependency. advice?

@alongosz

alongosz commented Aug 7, 2026

Copy link
Copy Markdown
Member Author

I guess you're doing it for other repos as well, and it would make sense to have a consistent approach for all Engineering repos - we're ignoring the Use full commit SHA hash for this dependency. advice?

@mnocon my rules are:

  1. if repo used commit SHA, use commit SHA
  2. if it's actions/* GHA, use @v notation (doesn't matter if it's tag or branch)
  3. if it's ibexa/* GHA feel free to use @main, it's safe
  4. if it's anything else, use commit SHA

Here 4) got intentionally violated, keeping rather your convention, to avoid confusing y'all and producing maintenance cost.
BUT if you prefer SHAs everwhere, it's easy to change.

I'm not going to do SHA everywhere for all other packages, because it's a huge maintenance cost. Every time a bug-fix comes out for that action, it requires updating. For instance GHSA-5wxr-w449-57cm on shivammathur/setup-php - fixed in v2.37.1. @v2 "floating" tag satisfies that fix without touching repos using it. Using SHA everywhere instead requires to update all workflows using this action in all repos.

It's not an ideal situation because malicious actor can force-push a tag, especially a floating one. For that reason gh-workflows will use SHA pinning instead of tags or branches for all non-ibexa actions. If it's in one place, it's manageable.

If we find good way to bulk update these, with Claude, then we might change the approach and use SHA everywhere. Or explicit tag, as long as action maintainer enabled immutable releases.

@mnocon do you want me to switch here to SHAs? It could be one of the exceptional packages, along with gh-workflows and AFAIR archive-maker too, actually.

@mnocon mnocon left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alongosz Thank you for the explanation, I think it's fine - we can always revisit this in the future if needed.

Ok for me to merge this, please let me know (here or on Slack) if you want to handle the cherry-pick yourself (to the following branches: 4.6, 6.0, saas) or I should do this (I'm fine with both options)

Bumped uses: refs to their latest release across all workflows, and
standardized runs-on to ubuntu-26.04 per the bundle-generator skeleton.
Kept existing pin styles (branch aliases and SHA pins) unchanged.
The build job relied on the runner's default PHP, which was compatible
under ubuntu-latest but ubuntu-26.04 ships PHP 8.5, exceeding
PHP CS Fixer's supported max of 8.3.
@alongosz
alongosz force-pushed the ibx-11778-update-gha-workflows branch from af8ecde to ea2b5e3 Compare August 31, 2026 16:52
Comment thread .github/workflows/build.yaml Dismissed
@alongosz
alongosz merged commit 9f3db05 into 5.0 Sep 1, 2026
11 of 12 checks passed
@alongosz
alongosz deleted the ibx-11778-update-gha-workflows branch September 1, 2026 11:56
alongosz added a commit that referenced this pull request Sep 1, 2026
For more details see https://ibexa.atlassian.net/browse/IBX-11778 and #3345

Key changes:

* Bumped all `uses:` action references in `.github/workflows/` to their latest versions, preserving existing pin styles

* Standardized `runs-on:` runner labels to ubuntu-26.04

* Fixed PHP CS Fixer failure on ubuntu-26.04 by pinning PHP 8.3
alongosz added a commit that referenced this pull request Sep 1, 2026
For more details see https://ibexa.atlassian.net/browse/IBX-11778 and #3345

Key changes:

* Bumped all `uses:` action references in `.github/workflows/` to their latest versions, preserving existing pin styles

* Standardized `runs-on:` runner labels to ubuntu-26.04

* Fixed PHP CS Fixer failure on ubuntu-26.04 by pinning PHP 8.3
alongosz added a commit that referenced this pull request Sep 1, 2026
For more details see https://ibexa.atlassian.net/browse/IBX-11778 and #3345

Key changes:

* Bumped all `uses:` action references in `.github/workflows/` to their latest versions, preserving existing pin styles

* Standardized `runs-on:` runner labels to ubuntu-26.04

* Fixed PHP CS Fixer failure on ubuntu-26.04 by pinning PHP 8.3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants