IBX-11778: Updated GitHub Actions to latest versions - #3345
Conversation
|
Preview of modified files: no change to preview. |
Summary
Timeouts per inputTimeouts in site/content_management/field_types/type_and_value/index.html
Redirects per inputRedirects in site/ai/ai_actions/configure_ai_actions/index.html |
|
I guess you're doing it for other repos as well, and it would make sense to have a consistent approach for all Engineering repos - we're ignoring the |
@mnocon my rules are:
Here 4) got intentionally violated, keeping rather your convention, to avoid confusing y'all and producing maintenance cost. I'm not going to do SHA everywhere for all other packages, because it's a huge maintenance cost. Every time a bug-fix comes out for that action, it requires updating. For instance GHSA-5wxr-w449-57cm on It's not an ideal situation because malicious actor can force-push a tag, especially a floating one. For that reason gh-workflows will use SHA pinning instead of tags or branches for all non-ibexa actions. If it's in one place, it's manageable. If we find good way to bulk update these, with Claude, then we might change the approach and use SHA everywhere. Or explicit tag, as long as action maintainer enabled immutable releases. @mnocon do you want me to switch here to SHAs? It could be one of the exceptional packages, along with gh-workflows and AFAIR archive-maker too, actually. |
mnocon
left a comment
There was a problem hiding this comment.
@alongosz Thank you for the explanation, I think it's fine - we can always revisit this in the future if needed.
Ok for me to merge this, please let me know (here or on Slack) if you want to handle the cherry-pick yourself (to the following branches: 4.6, 6.0, saas) or I should do this (I'm fine with both options)
Bumped uses: refs to their latest release across all workflows, and standardized runs-on to ubuntu-26.04 per the bundle-generator skeleton. Kept existing pin styles (branch aliases and SHA pins) unchanged.
The build job relied on the runner's default PHP, which was compatible under ubuntu-latest but ubuntu-26.04 ships PHP 8.5, exceeding PHP CS Fixer's supported max of 8.3.
af8ecde to
ea2b5e3
Compare
For more details see https://ibexa.atlassian.net/browse/IBX-11778 and #3345 Key changes: * Bumped all `uses:` action references in `.github/workflows/` to their latest versions, preserving existing pin styles * Standardized `runs-on:` runner labels to ubuntu-26.04 * Fixed PHP CS Fixer failure on ubuntu-26.04 by pinning PHP 8.3
For more details see https://ibexa.atlassian.net/browse/IBX-11778 and #3345 Key changes: * Bumped all `uses:` action references in `.github/workflows/` to their latest versions, preserving existing pin styles * Standardized `runs-on:` runner labels to ubuntu-26.04 * Fixed PHP CS Fixer failure on ubuntu-26.04 by pinning PHP 8.3
For more details see https://ibexa.atlassian.net/browse/IBX-11778 and #3345 Key changes: * Bumped all `uses:` action references in `.github/workflows/` to their latest versions, preserving existing pin styles * Standardized `runs-on:` runner labels to ubuntu-26.04 * Fixed PHP CS Fixer failure on ubuntu-26.04 by pinning PHP 8.3
Related PRs:
Description:
Bumped all
uses:action references in.github/workflows/to their latest versions, and standardizedruns-on:toubuntu-26.04(the current standard derived from theibexa/bundle-generatoribexa-ossskeleton).Most bumps are MAJOR version jumps (repos hadn't been touched in a while):
actions/checkoutv3/v4 → v7actions/setup-pythonv3/v5 → v7stefanzweifel/git-auto-commit-actionv4 → v7DavidAnson/markdownlint-cli2-actionv20 → v24vale-cli/vale-actionv2 → v3actions/create-github-app-tokenv2 → v3actions/upload-artifactv4 → v7peter-evans/find-commentv3 → v4actions/github-scriptv6 → v9peter-evans/create-or-update-commentv4 → v5actions/setup-nodev4 → v7peter-evans/create-pull-requestv7 → v8actions/cachev4 → v6Pin styles were preserved, not changed:
ramsey/composer-installandmarocchino/sticky-pull-request-commentare pinned to version branches (v3/v2→v4/v3) in most files — kept as branch pins per that convention.ramsey/composer-installinrelease_composer_package.yamlis SHA-pinned separately — bumped the SHA to the4.0.0tag, kept the SHA-pin style.shivammathur/setup-php(SHA pin) andlycheeverse/lychee-action(SHA pin) were already current, no change.ibexa/gh-workflows/...@main(reviewers.yaml) is a deliberate trunk-tracking pin, left untouched.For QA:
No functional changes expected; this only bumps CI tooling versions and the runner image.
Documentation:
Review
🤖 Generated with Claude Code