Skip to content

4.6 tested PHP versions - #3097

Merged
adriendupuis merged 19 commits into
4.6from
update-php-4.6
Mar 19, 2026
Merged

adriendupuis merged 19 commits into
4.6from
update-php-4.6

Conversation

@adriendupuis

@adriendupuis adriendupuis commented Mar 18, 2026 •

Copy link
Copy Markdown
Contributor
Question Answer
JIRA Ticket N/A
Versions 4.6
Edition N/A

Test with upper, lower alive, and lower dead versions of PHP

  • Add PHP 8.4, 8.2, and 7.4 to code-samples-validation CI test suite
  • Remove PHP 8.3
  • Fixes to satisfy tests in all three versions

Checklist

  • Text renders correctly
  • Text has been checked with vale
  • Description metadata is up to date
  • Redirects cover removed/moved pages
  • Code samples are working
  • PHP code samples have been fixed with PHP CS fixer
  • Added link to this PR in relevant JIRA ticket or code PR

@adriendupuis adriendupuis changed the title Update php 4.6 4.6 tested PHP versions Mar 18, 2026
@github-actions

github-actions Bot commented Mar 18, 2026 •

Copy link
Copy Markdown

Preview of modified files

Preview of modified Markdown:

@adriendupuis adriendupuis mentioned this pull request Mar 18, 2026
7 tasks
@adriendupuis
adriendupuis marked this pull request as ready for review March 18, 2026 18:05

@mnocon mnocon left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image

Code looks good, but the usage still needs to be adjusted? In extend_discounts_wizard and browsing_content

@github-actions

Copy link
Copy Markdown

code_samples/ change report

Report's diff is too long to be displayed in a comment.

Download colorized diff

@sonarqubecloud

Copy link
Copy Markdown

@adriendupuis

Copy link
Copy Markdown
Contributor Author

Code looks good, but the usage still needs to be adjusted? In extend_discounts_wizard and browsing_content

@mnocon
Offsets fixed in 0b8f556...a211732
The last code_samples_usage.diff.html now looks good to me but please check one more time.

@adriendupuis
adriendupuis requested a review from mnocon March 19, 2026 09:41

@mnocon mnocon left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@adriendupuis
adriendupuis merged commit 5259b7a into 4.6 Mar 19, 2026
12 checks passed
@adriendupuis
adriendupuis deleted the update-php-4.6 branch March 19, 2026 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants