Repository navigation
Added option to remove indent from code samples - #3081
Merged
Merged
Conversation
Preview of modified filesPreview of modified Markdown: |
mnocon
marked this pull request as ready for review
March 19, 2026 08:10
ibexa-workflow-automation-1
Bot
requested review from
adriendupuis,
dabrt and
julitafalcondusza
and removed request for
a team
March 19, 2026 08:10
adriendupuis
approved these changes
Mar 26, 2026
adriendupuis
left a comment
adriendupuis
left a comment
Contributor
There was a problem hiding this comment.
I tested with https://doc.ibexa.co/en/5.0/administration/recent_activity/recent_activity/#context-group VS https://ez-systems-developer-documentation--3081.com.readthedocs.build/en/3081/administration/recent_activity/recent_activity/#context-group and it works really well!
Python code is hard to read but the way it get how many spaces it can remove with indent = min(len(l) - len(l.lstrip()) for l in non_empty) looks solid to me.
|
mnocon
added a commit
that referenced
this pull request
Mar 31, 2026
* Added remove_indent * Usage example * recent_activity.md: remove_indent --------- Co-authored-by: Adrien Dupuis <61695653+adriendupuis@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Target: 4.6, 5.0
Improving readability of the code samples by reducing their indent where it's not meaningful.
It should not be enabled by default, because it can result in wrong indent when a code sample is composed of multiple include_file calls (the indentation would break then).
I've decided to keep the indent for YAML services - it might make things easier when copy/pasting (assuming someone is using 4-spaces indent)
Before:
After: