Skip to content

Improved TOC header navigation for headers nested in tabs - #3010

Merged
mnocon merged 1 commit into
5.0from
improve-header-navigation
Jan 20, 2026
Merged

mnocon merged 1 commit into
5.0from
improve-header-navigation

Conversation

@mnocon

@mnocon mnocon commented Jan 15, 2026 •

Copy link
Copy Markdown
Contributor

Target: 4.6, 5.0

Issue reported on Slack.

Disclaimer: code is heavily AI-generated, but I've reviewed and tested it dilligently - hope I didn't miss anything.

One test scenario:
go to https://ez-systems-developer-documentation--3010.com.readthedocs.build/en/3010/update_and_migration/from_4.6/update_from_4.6/ and click on the headers (in the right TOC) in the "LTS updates" section - the tab should be activated automatically.

@github-actions

Copy link
Copy Markdown

Preview of modified files: no change to preview.

@mnocon
mnocon marked this pull request as ready for review January 15, 2026 07:45
@mnocon
mnocon requested a review from reithor January 15, 2026 07:47

@reithor reithor left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - tested on chrome and opera.

One thing though:
May be it's semantically not 100% correct to use tabs for LTS updates in https://doc.ibexa.co/en/5.0/update_and_migration/from_4.6/update_from_4.6/#lts-updates
Tabs are fine when having a group of very similar things (like MySql|Postgres Headless|Experience|Commerce). Probably it is better to avoid Tabs for LTS Updates ?

@mnocon

mnocon commented Jan 15, 2026

Copy link
Copy Markdown
Contributor Author

The idea I had is that it's easier to quickly check the tab for each LTS update you use - having it without tabs would mean that you read through every LTS update section even when not using it.

But it's something we can discuss within the team

@mnocon
mnocon requested a review from a team January 19, 2026 14:46
@ibexa-workflow-automation-1
ibexa-workflow-automation-1 Bot requested review from adriendupuis, dabrt and julitafalcondusza and removed request for a team January 19, 2026 14:47
@dabrt

dabrt commented Jan 20, 2026

Copy link
Copy Markdown
Contributor

The script still hiccups - when you try switching back and forth, the focus does not follow. For example, when you click Symbol attribute tab header and then Discounts, the focus ends up in "Form Builder performance fix..."
Another example:
obraz

@reithor

reithor commented Jan 20, 2026

Copy link
Copy Markdown
Contributor

The script still hiccups - when you try switching back and forth, the focus does not follow. For example, when you click Symbol attribute tab header and then Discounts, the focus ends up in "Form Builder performance fix..."

seems not related to the new script - current status is already not 100% accurate - https://doc.ibexa.co/en/5.0/update_and_migration/from_4.6/update_from_4.6/#__tabbed_9_1

@adriendupuis adriendupuis left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to find the right tab for any section's heading

@mnocon
mnocon merged commit 501ceb5 into 5.0 Jan 20, 2026
12 checks passed
@mnocon
mnocon deleted the improve-header-navigation branch January 20, 2026 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants