[v5] Fixed invalid code sample includes - #2967
Merged
Merged
Conversation
mnocon
marked this pull request as ready for review
December 3, 2025 09:22
ibexa-workflow-automation-1
Bot
requested review from
adriendupuis,
dabrt and
julitafalcondusza
and removed request for
a team
December 3, 2025 09:22
adriendupuis
reviewed
Dec 3, 2025
adriendupuis
left a comment
Contributor
There was a problem hiding this comment.
Few highlight offsets and unneeded new lines.
Few $output->writeln are not really necessary and narrow the example to CLI, but some are really important to fastly illustrate properties and/or looping; could be debated.
Co-authored-by: Adrien Dupuis <61695653+adriendupuis@users.noreply.github.com>
Contributor
Author
|
@adriendupuis suggestions applied in 933f2e3 Then manual changes in 010022f and 6ce757c Thank you for your review! |
code_samples/ change report
|
adriendupuis
approved these changes
Dec 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the wrong file includes in different files of the doc (after I've broken them when upgrading the code to v5).