IBX-9680: Extending discounts - #2936
Merged
Merged
Conversation
mnocon
force-pushed
the
extend-discounts
branch
from
November 26, 2025 23:15
1eab7ae to
c2157dc
Compare
konradoboza
reviewed
Dec 1, 2025
konradoboza
left a comment
Contributor
There was a problem hiding this comment.
Great work! I reviewed mostly part related to extending API, I will let Paweł check extending the discount wizard. A few remarks:
konradoboza
approved these changes
Dec 1, 2025
Co-authored-by: Paweł Niedzielski <pawel.niedzielski@ibexa.co>
ibexa-workflow-automation-1
Bot
requested review from
adriendupuis,
dabrt and
julitafalcondusza
and removed request for
a team
December 9, 2025 10:40
adriendupuis
requested changes
Dec 9, 2025
Co-authored-by: Adrien Dupuis <61695653+adriendupuis@users.noreply.github.com>
adriendupuis
left a comment
Contributor
There was a problem hiding this comment.
The expression concept could be explained and illustrated a bit more. I think I get confuse with the usage of expression identifier, expression function, and expression value.
Co-authored-by: Adrien Dupuis <61695653+adriendupuis@users.noreply.github.com>
Contributor
Author
|
@adriendupuis improved after your review in 4bd5562 |
adriendupuis
requested changes
Dec 12, 2025
adriendupuis
left a comment
Contributor
There was a problem hiding this comment.
Really good improvements in 4bd5562
Just few details left
Co-authored-by: Adrien Dupuis <61695653+adriendupuis@users.noreply.github.com>
code_samples/ change report
|
adriendupuis
approved these changes
Dec 12, 2025
mnocon
added a commit
that referenced
this pull request
Dec 14, 2025
* [WIP] Current status * PHP & JS CS Fixes * Started working on Forms * Current status * Current status * PHPStan is passing * Conditions ready * Conditions refactored * Extending wizard * FInal touches * Fixes before review * PHP & JS CS Fixes * Rebuild * Review fixes * PHP & JS CS Fixes * Removed not needed code sample ranges * Added a note about variable vs function * Update docs/discounts/extend_discounts.md Co-authored-by: Paweł Niedzielski <pawel.niedzielski@ibexa.co> * Added note about simplified implementation * Apply suggestions from code review Co-authored-by: Adrien Dupuis <61695653+adriendupuis@users.noreply.github.com> * Refactored the tables * Apply suggestions from code review Co-authored-by: Adrien Dupuis <61695653+adriendupuis@users.noreply.github.com> * Review fixes * Apply suggestions from code review Co-authored-by: Adrien Dupuis <61695653+adriendupuis@users.noreply.github.com> * Added better formatting prices * Removed not needed output --------- Co-authored-by: Paweł Niedzielski <pawel.niedzielski@ibexa.co> Co-authored-by: Adrien Dupuis <61695653+adriendupuis@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Things added:
Preview:
Previews: