IBX-12331: Updated typography tokens and Storybook to the Figma spec - #146
Open
tischsoic wants to merge 1 commit into
Open
IBX-12331: Updated typography tokens and Storybook to the Figma spec#146tischsoic wants to merge 1 commit into
tischsoic wants to merge 1 commit into
Conversation
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
alekmick
approved these changes
Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related PRs:
Description:
Completes the typography harmonization with the Figma parameters table (node 370-18633): body and code get named tokens and mixins the way headings already have them, and the Storybook typography story now mirrors Figma's sections and values.
variables/_typography.scss:$body-xl/l/m/s/xs-font-size(18/16/14/12/10, aliasing the$text-font-size-*ramp),$code-l/m/s-font-size(16/14/12),$text-highlighted-font-size-2xl(18 — new row in Figma),$body-line-height/$code-line-height(1.5)._body.scss(body-xl…body-xs($weight, $style)— Mulish, 400/600, normal/italic) and_code.scss(code-l/m/s— JetBrains Mono 400), registered instyles.scss; like_headers.scssthey emit nothing — compileddist/css/styles.cssis byte-identical.$text-font-size-2xl/3xlstay defined (admin-ui_login.scssand segmentation_audience-table.scssstill use them) but are no longer documented; they go with the admin-ui follow-up.Designer confirmed (2026-09-11) that every line-height is 150% of the size, as the table states — the six Figma text styles whose bound variables disagree (h3, h4, highlighted-xl/l/2xl line-heights; code-l size 15 vs 16) are being fixed in Figma; no code impact.
Follow-ups (separate tickets): admin-ui body/small/code Bootstrap wiring (
<code>currently renders Bootstrap's$pink), letter-spacing 0.12px vs Figma 0,$base-font-sizenot!default, unused Noto Sans / Work Sans@font-faceblocks.For QA:
Storybook → Typography: tables for Header, Highlighted, Body (4 variants), Code with the values from the Figma table; no Links table. Computed styles at the 14px root:
body-xl18px/27px,body-xs10px/15px,code-l16px/24px in JetBrains Mono,highlighted-2xl18px/27px; italic rows render a real italic face.Documentation:
🤖 Generated with Claude Code