Skip to content

IBX-12648: [Composer] Added conflict with twig/twig 3.29+ incompatible with Symfony 5.4 - #838

Open
alongosz wants to merge 1 commit into
4.6from
ibx-12648-twig-329-symfony-54
Open

alongosz wants to merge 1 commit into
4.6from
ibx-12648-twig-329-symfony-54

Conversation

@alongosz

Copy link
Copy Markdown
Member
🎫 Issue IBX-12648

Description:

twig/twig 3.29.0 changed Twig\TemplateWrapper::unwrap() to require a Twig\Environment argument. symfony/twig-bundle 5.4.45 calls it without one, so cache warm-up fatals on every 4.6 instance:

PHP Fatal error:  Uncaught ArgumentCountError: Too few arguments to function Twig\TemplateWrapper::unwrap(),
0 passed in vendor/symfony/twig-bundle/CacheWarmer/TemplateCacheWarmer.php on line 56 and exactly 1 expected
in vendor/twig/twig/src/TemplateWrapper.php:110

All 4.6 browser tests in the org went red the same day - 21 failing jobs across admin-ui, page-builder, form-builder, fieldtype-richtext, segmentation and commerce.

Symfony capped twig to <3.29.0 on their 5.4 branch (symfony/symfony@003d08c8c82f, symfony/symfony@7ec3eb09ec5e), but hasn't released it - the cap landed on 2026-09-14, and the latest 5.4 release is v5.4.53 from 2026-05-27. This mirrors it until a 5.4 release carrying it ships.

  • [Composer] Added twig/twig: >=3.29 to conflict

Important

4.6 only. 6.4 and 7.4 avoid the call via Twig\BlockChain (symfony/symfony#66043), so this hunk must be dropped on merge-up to 5.0.

There's a second call site we don't hit yet only because cache warm-up dies first: TwigRendererEngine::loadResourcesFromTheme(), used when rendering form themes.

For QA:

No QA required. With the conflict in place composer resolves twig/twig to 3.28.0 and leaves symfony/twig-bundle at v5.4.45.

Documentation:

No documentation required.

🤖 Generated with Claude Code

…ony 5.4

twig/twig 3.29.0 changed Twig\TemplateWrapper::unwrap() to require a
Twig\Environment argument. symfony/twig-bundle 5.4.45 calls it without
one, so cache warm-up fatals on every 4.6 instance.

Symfony capped twig to <3.29.0 on their 5.4 branch on 2026-09-14, but
has not released it - the latest 5.4 release is v5.4.53 from 2026-05-27.
This mirrors that cap until a 5.4 release carrying it ships.

4.6 only: 6.4 and 7.4 avoid the call via Twig\BlockChain, so this hunk
must be dropped on merge-up to 5.0.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@alongosz
alongosz force-pushed the ibx-12648-twig-329-symfony-54 branch from 8a4fcc7 to 97a64c6 Compare September 18, 2026 19:40
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant