IBX-6773: [Tests] Used bookmark gateway constants instead of hardcoded table and column names - #835
Merged
Merged
Conversation
alongosz
approved these changes
Sep 16, 2026
konradoboza
approved these changes
Sep 17, 2026
|
Contributor
Author
|
Re-requesting approval as I added one more commit, ref discussion in #834 (comment) |
alongosz
approved these changes
Sep 17, 2026
konradoboza
approved these changes
Sep 17, 2026
bnowak
approved these changes
Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description:
Three tests referred to database tables and columns by string literal. The bookmark table was renamed from
ezcontentbrowsebookmarktoibexa_content_bookmarkbetween 4.6 and 5.0, so those literals did not survive the last merge up.The gateway already exposes the names as constants:
DoctrineDatabase::TABLE_BOOKMARKSandCOLUMN_*.Using them in
LocationServiceTestandIsBookmarkedQueryBuilderTestkeeps both tests correct across a rename, and keeps the expected sub-query inIsBookmarkedQueryBuilderTestin step with what the query builder actually produces.IdSortClauseQueryBuilderTesthad the same problem with the content item table, renamed fromezcontentobjecttoibexa_content; it now usesContent\Gateway::CONTENT_ITEM_TABLEalongside the two table constants it already used. That one stayed unnoticed because the test asserts on the generated SQL without ever executing it.For QA:
Documentation: