Conversation
) For more details see https://ibexa.atlassian.net/browse/IBX-6773 and #476 Key changes: * Fixed `BookmarkService::loadBookmarks()` throwing an exception when the bookmark list contained locations the current user no longer has access to, by resolving bookmarks through filtering instead of `LocationService::loadLocation()`. * Extended `Criterion\Location\IsBookmarked` to support filtering via both `LocationService::find()`/`count()` and `ContentService::find()` (matching main Locations only for Content filtering). * Added `SortClause\Location\Bookmark\Id` and its query builders to allow sorting filtered bookmark results by recency. * Deprecated `Handler::loadUserBookmarks()`, `Handler::countUserBookmarks()` and their Gateway counterparts in favor of `LocationService::find()`/`count()` with `Criterion\Location\IsBookmarked`. * Made `BookmarkService` log and return an empty list instead of failing when the underlying filter query throws a repository exception. --------- Co-Authored-By: Paweł Niedzielski <3183926+Steveb-p@users.noreply.github.com> Co-Authored-By: Andrew Longosz <7099219+alongosz@users.noreply.github.com>
|
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Caution
This is a merge pull request
Related PRs: