Conversation
ibexa-workflow-automation-1
Bot
requested review from
Steveb-p,
ViniTou,
alongosz,
barw4,
bnowak,
ciastektk,
konradoboza,
mikadamczyk,
tbialcz and
wiewiurdp
and removed request for
a team
September 14, 2026 11:52
Sztig
force-pushed
the
IBX-12460-external-storage-field-identifier-fix
branch
from
September 16, 2026 08:18
b0c62e4 to
f4d462a
Compare
|
Contributor
Author
|
Code analysis fails due to the tests already being marked for code duplication before my additions, to fix that I would need to completely refactor these 3 test classes |
mikadamczyk
approved these changes
Sep 16, 2026
| $this->assertImageExists(false, $ioService, $content); | ||
| } | ||
|
|
||
| private function downgradeFieldTypeIdentifierToLegacyAlias( |
Contributor
There was a problem hiding this comment.
downgradeFieldTypeIdentifierToLegacyAlias() is duplicated in UserIntegrationTest.php (only the hardcoded value differs). It might be worth hoisting it to BaseIntegrationTestCase, but not blocking if you'd rather keep it local.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
When field types were renamed in 5.0 (
ezimage->ibexa_imageetc.), the old names are still in use and kept in thedata_type_stringcolumn for the content that already existed (given that the ibexa instance was upgraded from 4.x to 5.0).Deletion of content has a bug - it does not recognize old data types registered storage types giving them all
NullStorage, in consequence when deleting content the external data is not being processed.Fix:
FieldHandlernow runs the gateways result throughFieldTypeAliasResolverbefore handing anything to the storage handler. We are running same values with just updated keys to match new filed types naming.Regarding the tests -
FieldHandlerTestcover the resolution and merging for all seven affected types. Two integration tests cover the actual flow when deleting the content: they publish content, put the legacy identifier back in the database to reproduce an unmigrated installation, delete the content and then check if the external data is really gone.Additional note - this only fixes the deletion mechanism, no cleanup of old data was addressed here.
For QA:
Documentation: