IBX-6773: Fixed loading Bookmarks for non-accessible content items - #476

Open

vidarl wants to merge 15 commits into

4.6from

IBX-6773_Bookmarks_for_non-accessible_contents_cause_exception_4.6

Commits on Sep 11, 2026

IBX-6773: Bookmarks for non-accessible contents cause exception

vidarl
authored and
KamilSznajdrowicz
committed
0cc8091
Aligned PHPStan baseline with the bookmark changes

authored and
KamilSznajdrowicz
committed
8906ad5
Consolidate IsBookmarked criterion into Criterion\Location\IsBookmarked

vidarl
authored and
KamilSznajdrowicz
committed
22773af
Tests: Extend IsBookmarked true/false coverage to Content filtering

vidarl
authored and
KamilSznajdrowicz
committed
87679d7
Review comment: Throw Core InvalidArgumentException from IsBookmarkedQueryBuilder

vidarl
authored and
KamilSznajdrowicz
committed
c0dddfd
Move IsBookmarked integration tests into LocationFilteringTest/ContentFilteringTest and LocationFilteringTest

vidarl
authored and
KamilSznajdrowicz
committed
8953c21
Review comment: Use ALIAS/COLUMN_LOCATION_ID consts and @param docblock in IsBookmarkedQueryBuilder

vidarl
authored and
KamilSznajdrowicz
committed
0c995ac
Review comment: Document Content filtering matches main Locations only in IsBookmarked criterion

vidarl
authored and
KamilSznajdrowicz
committed
4e223f8
Review comment: Use Core InvalidArgumentException, and(), and @internal in IdSortClauseQueryBuilder

vidarl
authored and
KamilSznajdrowicz
committed
976d801
Review comment: Extend SortClause\Location instead of SortClause in Bookmark\Id

vidarl
authored and
KamilSznajdrowicz
committed
7c4d80f
Review comment: Simplify BookmarkService constructor doc, catch RepositoryException, log at error level

vidarl
authored and
KamilSznajdrowicz
committed
c035aa5
Review comment: Rename BookmarkQueryBuilderTest to IsBookmarkedQueryBuilderTest

vidarl
authored and
KamilSznajdrowicz
committed
cb6bddb
Review comment: Bump Bookmark deprecation tags to 4.6.32

vidarl
authored and
KamilSznajdrowicz
committed
5a63326
Review comment: Reuse BaseLocationSortClauseQueryBuilder in bookmark Id sort clause

vidarl
authored and
KamilSznajdrowicz
committed
a0dcc03
Added regression tests for bookmarks of inaccessible and removed items

vidarl
authored and
KamilSznajdrowicz
committed
daec766

Navigation Menu

Uh oh!

IBX-6773: Fixed loading Bookmarks for non-accessible content items - #476

IBX-6773: Fixed loading Bookmarks for non-accessible content items#476
vidarl wants to merge 15 commits into
4.6from
IBX-6773_Bookmarks_for_non-accessible_contents_cause_exception_4.6

Commits on Sep 11, 2026

IBX-6773: Bookmarks for non-accessible contents cause exception

Aligned PHPStan baseline with the bookmark changes

Consolidate IsBookmarked criterion into Criterion\Location\IsBookmarked

Tests: Extend IsBookmarked true/false coverage to Content filtering

Review comment: Throw Core InvalidArgumentException from IsBookmarkedQueryBuilder

Move IsBookmarked integration tests into LocationFilteringTest/ContentFilteringTest and LocationFilteringTest

Review comment: Use ALIAS/COLUMN_LOCATION_ID consts and @param docblock in IsBookmarkedQueryBuilder

Review comment: Document Content filtering matches main Locations only in IsBookmarked criterion

Review comment: Use Core InvalidArgumentException, and(), and @internal in IdSortClauseQueryBuilder

Review comment: Extend SortClause\Location instead of SortClause in Bookmark\Id

Review comment: Simplify BookmarkService constructor doc, catch RepositoryException, log at error level

Review comment: Rename BookmarkQueryBuilderTest to IsBookmarkedQueryBuilderTest

Review comment: Bump Bookmark deprecation tags to 4.6.32

Review comment: Reuse BaseLocationSortClauseQueryBuilder in bookmark Id sort clause

Added regression tests for bookmarks of inaccessible and removed items