IBX-12533: Fixed JsonToArrayTransformer rejecting empty string values - #125
Open
mateuszdebinski wants to merge 2 commits into
Open
mateuszdebinski wants to merge 2 commits into
mateuszdebinski wants to merge 2 commits into
Conversation
ibexa-workflow-automation-1
Bot
requested review from
Steveb-p,
ViniTou,
alongosz,
barw4,
bnowak,
ciastektk,
konradoboza,
mikadamczyk,
tbialcz and
wiewiurdp
and removed request for
a team
September 21, 2026 12:59
mateuszdebinski
force-pushed
the
IBX-12533-Empty-regex-validators-cause-errors
branch
from
September 21, 2026 13:01
6dff910 to
09c087a
Compare
mikadamczyk
approved these changes
Sep 23, 2026
konradoboza
reviewed
Sep 23, 2026
|
konradoboza
approved these changes
Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
The fix adds an explicit
$value === ''check alongside$value === null.empty($value)was deliberately avoided, since it would also catch valid JSON scalars like "0", incorrectly treating legitimate data as empty.For QA:
Documentation: