Added rule for splitting multiple methods arguments into multiline if there is more than one - #13
Merged
Merged
Conversation
ViniTou
changed the title
alongosz
reviewed
Oct 10, 2025
alongosz
left a comment
alongosz
left a comment
Member
There was a problem hiding this comment.
+1 but we need to address a static analysis issue
| self::assertSame($expected, $tokens->generateCode()); | ||
| } | ||
|
|
||
| public static function provideFixCases(): iterable |
Member
There was a problem hiding this comment.
Missing iterable type. Looks like phpstan.neon never got updated paths when we introduced ./tests directory 😅
Contributor
Author
There was a problem hiding this comment.
Yup, that was the case, added to phpstan configuration and fixed all issues.
Added tests folder to phpstan
konradoboza
reviewed
Oct 13, 2025
konradoboza
approved these changes
Oct 13, 2025
konradoboza
left a comment
konradoboza
left a comment
There was a problem hiding this comment.
+1 but this one wasn't yet fixed #13 (comment).
Member
|
@ViniTou Rebase is needed here |
ViniTou
force-pushed
the
multiline-rule
branch
from
October 14, 2025 11:47
3d2ccf8 to
f143ece
Compare
|
adamwojs
approved these changes
Oct 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…
Description:
For QA:
Documentation: