IBX-9217: SELENIUM_IMAGE update to version 124.0-20250202 - #131
Merged
Conversation
This was referenced Feb 17, 2025
|
This was referenced Feb 19, 2025
micszo
marked this pull request as ready for review
February 19, 2025 12:24
tomaszszopinski
approved these changes
Feb 20, 2025
KamilSznajdrowicz
approved these changes
Feb 20, 2025
katarzynazawada
approved these changes
Feb 27, 2025
micszo
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related PRs:
Description:
This PR changes two things:
There is a performance drop visible compared to v110. It affects different places e.g. Content Tree, Search, saving forms after creating/editing, previewing content.
Content Treehttps://github.com/ibexa/commerce/actions/runs/13260773669/job/37016681623#step:18:120
https://res.cloudinary.com/ezplatformtravis/image/upload/v1739271136/screenshots/67ab2be0b5609332224433-vendor_ibexa_admin-ui_features_standard_fields_media_feature_75_hsu9hk.png
https://github.com/ibexa/commerce/actions/runs/13260773669/job/37016683608#step:18:386
https://res.cloudinary.com/ezplatformtravis/image/upload/v1739272085/screenshots/67ab2f9580fe7897711044-vendor_ibexa_admin-ui_features_standard_trash_feature_69_nwa0rd.png
https://github.com/ibexa/commerce/actions/runs/13260773669/job/37016683955#step:18:193
https://res.cloudinary.com/ezplatformtravis/image/upload/v1739271832/screenshots/67ab2e9659915063148148-vendor_ibexa_page-builder_features_dynamiclandingpage_blocks_contentscheduler_feature_29_bzke9t.png
Searchhttps://github.com/ibexa/commerce/actions/runs/13260773669/job/37016681244#step:18:319
https://res.cloudinary.com/ezplatformtravis/image/upload/v1739272496/screenshots/67ab312fb9914434330591-vendor_ibexa_product-catalog_features_browser_currencies_feature_7_cbprfm.png
https://github.com/ibexa/commerce/actions/runs/13260773669/job/37016681623#step:18:308
https://res.cloudinary.com/ezplatformtravis/image/upload/v1739271280/screenshots/67ab2c70b8db7108934058-vendor_ibexa_shipping_features_browser_shippingmethods_feature_139_yynwzf.png
https://github.com/ibexa/commerce/actions/runs/13260773669/job/37016681623#step:18:427
https://res.cloudinary.com/ezplatformtravis/image/upload/v1739271824/screenshots/67ab2e90bf6b5336180527-vendor_ibexa_payment_features_paymentmethods_feature_60_rrqvxb.png
saving forms after creating/editinghttps://github.com/ibexa/commerce/actions/runs/13260773669/job/37016683246#step:18:74
https://res.cloudinary.com/ezplatformtravis/image/upload/v1739270956/screenshots/67ab2b2b9c78f485724748-vendor_ibexa_admin-ui_features_standard_languages_feature_23_dy5sif.png
https://github.com/ibexa/commerce/actions/runs/13284262290/job/37089291628#step:18:365
https://res.cloudinary.com/ezplatformtravis/image/upload/v1739361004/screenshots/67ac8aec25ca9757778053-vendor_ibexa_admin-ui_features_standard_languages_feature_73_kcsyuu.png
previewing contenthttps://github.com/ibexa/commerce/actions/runs/13260773669/job/37016683246#step:18:202
https://res.cloudinary.com/ezplatformtravis/image/upload/v1739272039/screenshots/67ab2f66bafeb973607806-vendor_ibexa_admin-ui_features_standard_contentpreview_feature_12_glmheq.png
https://github.com/ibexa/commerce/actions/runs/13282723996/job/37084480786#step:18:262
https://res.cloudinary.com/ezplatformtravis/image/upload/v1739357054/screenshots/67ac7b7db12f6215298167-vendor_ibexa_admin-ui_features_standard_contentpreview_feature_12_jbfhg2.png
With newer versions of Chrome such random login failures started appearing again (ref. https://issues.ibexa.co/browse/IBX-4672). Approximately not more than once per regression build, in different feature files. The pattern appears to be when the "I am logged as admin" step is used between scenarios.
E.g.
taxonomy/features/Taxonomy.featurehttps://github.com/ibexa/commerce/actions/runs/13306722576/job/37170160019?pr=1186#step:18:73
https://res.cloudinary.com/ezplatformtravis/image/upload/v1739459309/screenshots/67ae0aed3405e581841505-vendor_ibexa_taxonomy_features_taxonomy_feature_28_p3pwbi.png
version-comparison/features/Fields/Media.featurehttps://github.com/ibexa/commerce/actions/runs/13287992755/job/37101289575#step:18:103
https://res.cloudinary.com/ezplatformtravis/image/upload/v1739372638/screenshots/67acb85e2b675143767375-vendor_ibexa_version-comparison_features_fields_media_feature_58_lijzsu.png
For QA:
Documentation: