IBX-12632, IBX-12408: Merged branch '5.0' into 6.0 - #2111
Merged
Merged
Conversation
…lectOption() (#2104) selectOption() called findAll() immediately after the dropdown was opened. BaseElement::findAll() only waits for raw CSS matches and applies the VisibleCSSLocator visibility criterion afterwards, so while the popover is in the DOM but not yet visible the collection comes back empty - no timeout, just "Collection is empty". Wait with ElementExistsCondition first, the way the sibling selectOptionByValueFragment() already does. Co-authored-by: barbaragr <barbara.grajczyk@ez.no> Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
# Conflicts: # src/bundle/ui-dev/src/modules/universal-discovery/components/finder/finder.leaf.js
# Conflicts: # src/bundle/ui-dev/src/modules/universal-discovery/components/finder/finder.leaf.js
|
barbaragr
marked this pull request as ready for review
September 22, 2026 18:42
tomaszszopinski
approved these changes
Sep 23, 2026
katarzynazawada
approved these changes
Sep 23, 2026
KamilSznajdrowicz
approved these changes
Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Caution
This is a merge pull request
Related PRs: