Skip to content

IBX-12606: Replaced the Symfony deprecation thresholds with PHPUnit's native deprecation gate #2100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
konradoboza merged 5 commits into from
Sep 23, 2026
Merged

IBX-12606: Replaced the Symfony deprecation thresholds with PHPUnit's native deprecation gate #2100

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
db55643
IBX-12606: Replaced the Symfony deprecation thresholds with PHPUnit's…
ViniTou Sep 17, 2026
1b88371
IBX-12606: Failed test runs on PHP notices and warnings to keep the P…
ViniTou Sep 18, 2026
800953e
IBX-12606: Dropped unused symfony/phpunit-bridge dependency
ViniTou Sep 18, 2026
8250487
IBX-12606: Gated the integration test suite on deprecations with a ba…
ViniTou Sep 23, 2026
46722c7
IBX-12606: Baselined the template deprecations reported by the transl…
ViniTou Sep 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,6 @@
"phpstan/phpstan-phpunit": "^2.0",
"phpstan/phpstan-symfony": "^2.0",
"phpunit/phpunit": "^11.5",
"symfony/phpunit-bridge": "^7.4",
"webmozart/assert": "^2.3"
},
"config": {
Expand Down
34 changes: 34 additions & 0 deletions phpunit.baseline.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
<?xml version="1.0"?>
<files version="1">
<file path="src/lib/Form/DataTransformer/ContentInfoTransformer.php">
<line number="48" hash="7354630459ee58656d1457552a873ddec12475a8">
<issue><![CDATA[ctype_digit(): Argument of type bool will be interpreted as string in the future]]></issue>
<issue><![CDATA[ctype_digit(): Argument of type array will be interpreted as string in the future]]></issue>
<issue><![CDATA[ctype_digit(): Argument of type stdClass will be interpreted as string in the future]]></issue>
<issue><![CDATA[ctype_digit(): Argument of type Ibexa\Contracts\Core\Repository\Values\Content\ContentInfo will be interpreted as string in the future]]></issue>
</line>
</file>
<file path="src/lib/Form/DataTransformer/ContentTypeGroupTransformer.php">
<line number="48" hash="7354630459ee58656d1457552a873ddec12475a8">
<issue><![CDATA[ctype_digit(): Argument of type bool will be interpreted as string in the future]]></issue>
<issue><![CDATA[ctype_digit(): Argument of type array will be interpreted as string in the future]]></issue>
<issue><![CDATA[ctype_digit(): Argument of type stdClass will be interpreted as string in the future]]></issue>
</line>
</file>
<file path="src/lib/Form/DataTransformer/RoleAssignmentTransformer.php">
<line number="52" hash="7354630459ee58656d1457552a873ddec12475a8">
<issue><![CDATA[ctype_digit(): Argument of type bool will be interpreted as string in the future]]></issue>
<issue><![CDATA[ctype_digit(): Argument of type float will be interpreted as string in the future]]></issue>
<issue><![CDATA[ctype_digit(): Argument of type array will be interpreted as string in the future]]></issue>
<issue><![CDATA[ctype_digit(): Argument of type stdClass will be interpreted as string in the future]]></issue>
</line>
</file>
<file path="src/lib/Form/DataTransformer/RoleTransformer.php">
<line number="51" hash="7354630459ee58656d1457552a873ddec12475a8">
<issue><![CDATA[ctype_digit(): Argument of type bool will be interpreted as string in the future]]></issue>
<issue><![CDATA[ctype_digit(): Argument of type float will be interpreted as string in the future]]></issue>
<issue><![CDATA[ctype_digit(): Argument of type array will be interpreted as string in the future]]></issue>
<issue><![CDATA[ctype_digit(): Argument of type stdClass will be interpreted as string in the future]]></issue>
</line>
</file>
</files>
32 changes: 32 additions & 0 deletions phpunit.integration.baseline.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
<?xml version="1.0"?>
<files version="1">
<file path="vendor/symfony/deprecation-contracts/function.php">
<line number="25" hash="c6af5d66288d0667e424978000f29571e4954b81">
<issue><![CDATA[Since symfony/config 7.4: Setting a default value to a required node is deprecated. Remove the default value from the node "min_query_length" or make it optional.]]></issue>
<issue><![CDATA[Since symfony/config 7.4: Setting a default value to a required node is deprecated. Remove the default value from the node "result_limit" or make it optional.]]></issue>
<issue><![CDATA[Since symfony/framework-bundle 7.3: Not setting the "property_info.with_constructor_extractor" option explicitly is deprecated because its default value will change in version 8.0.]]></issue>
<issue><![CDATA[Since symfony/dependency-injection 7.4: XML configuration format is deprecated, use YAML or PHP instead.]]></issue>
<issue><![CDATA[Since symfony/twig-component-bundle 2.13: Not setting the "twig_component.anonymous_template_directory" config option is deprecated. It will default to "components" in 3.0.]]></issue>
<issue><![CDATA[Since symfony/ux-twig-component 2.13: Not setting the "twig_component.defaults" config option is deprecated. Check the documentation for an example configuration.]]></issue>
<issue><![CDATA[Since symfony/dependency-injection 7.4: Service id "Ibexa\Rest\Server\Common\Parser" looks like a FQCN but no corresponding class or interface exists. To resolve this ambiguity, please rename this service to a non-FQCN (e.g. using dots), or create the missing class or interface.]]></issue>
<issue><![CDATA[Since symfony/dependency-injection 7.4: Service id "Ibexa\AdminUi\Form\Type\Search\DateIntervalType" looks like a FQCN but no corresponding class or interface exists. To resolve this ambiguity, please rename this service to a non-FQCN (e.g. using dots), or create the missing class or interface.]]></issue>
<issue><![CDATA[Since symfony/config 7.4: Setting a default value to a required node is deprecated. Remove the default value from the node "min_query_length" or make it optional.]]></issue>
<issue><![CDATA[Since symfony/config 7.4: Setting a default value to a required node is deprecated. Remove the default value from the node "result_limit" or make it optional.]]></issue>
<issue><![CDATA[Since symfony/framework-bundle 7.3: Not setting the "property_info.with_constructor_extractor" option explicitly is deprecated because its default value will change in version 8.0.]]></issue>
<issue><![CDATA[Since symfony/config 7.4: Setting a default value to a required node is deprecated. Remove the default value from the node "min_query_length" or make it optional.]]></issue>
<issue><![CDATA[Since symfony/config 7.4: Setting a default value to a required node is deprecated. Remove the default value from the node "result_limit" or make it optional.]]></issue>
<issue><![CDATA[Since ibexa/core 5.0: Since ibexa/core 5.0: The "Ibexa\Bundle\Core\ApiLoader\RepositoryConfigurationProvider" service is deprecated and will be removed in 6.0. Use Ibexa\Contracts\Core\Container\ApiLoader\RepositoryConfigurationProviderInterface instead]]></issue>
<issue><![CDATA[Since ibexa/core 5.0: Since ibexa/core 5.0: The "Ibexa\Bundle\Core\ApiLoader\RepositoryConfigurationProvider" service is deprecated and will be removed in 6.0. Use Ibexa\Contracts\Core\Container\ApiLoader\RepositoryConfigurationProviderInterface instead]]></issue>
<issue><![CDATA[Since ibexa/core 5.0: Since ibexa/core 5.0: The "Ibexa\Bundle\Core\ApiLoader\RepositoryConfigurationProvider" service is deprecated and will be removed in 6.0. Use Ibexa\Contracts\Core\Container\ApiLoader\RepositoryConfigurationProviderInterface instead]]></issue>
<issue><![CDATA[Since ibexa/core 5.0: Since ibexa/core 5.0: The "Ibexa\Bundle\Core\ApiLoader\RepositoryConfigurationProvider" service is deprecated and will be removed in 6.0. Use Ibexa\Contracts\Core\Container\ApiLoader\RepositoryConfigurationProviderInterface instead]]></issue>
<issue><![CDATA[Since twig/twig 3.28: Using the "macro" tag outside the root of a template is deprecated in /home/runner/work/admin-ui/admin-ui/src/bundle/DependencyInjection/../../../src/bundle/Resources/views/themes/admin/content/tab/url/modal_add_custom_url.html.twig at line 16.]]></issue>
<issue><![CDATA[Since ibexa/admin-ui 4.6.19: Twig Function "ibexa_render_component_group" is deprecated; use "ibexa_twig_component_group" instead in /home/runner/work/admin-ui/admin-ui/src/bundle/DependencyInjection/../../../src/bundle/Resources/views/themes/admin/ui/edit_header.html.twig at line 31.]]></issue>
<issue><![CDATA[Since twig/twig 3.28: Using the "use" tag outside the root of a template is deprecated in /home/runner/work/admin-ui/admin-ui/src/bundle/DependencyInjection/../../../src/bundle/Resources/views/themes/admin/ui/form_fields.html.twig at line 551.]]></issue>
</line>
</file>
<file path="vendor/ibexa/core/src/bundle/Core/DependencyInjection/Compiler/SlugConverterConfigurationPass.php">
<line number="62" hash="46c20ceb34da10cf5e5ad5215b58d86570f0d771">
<issue><![CDATA[Relying on default url_alias.slug_converter.transformation setting ("urlalias") is deprecated and might change in the next major. Set it explicitly to one of the following: urlalias, urlalias_iri, urlalias_compat, urlalias_lowercase]]></issue>
</line>
</file>
</files>
9 changes: 6 additions & 3 deletions phpunit.integration.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<?xml version="1.0"?>
<phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/11.5/phpunit.xsd" bootstrap="tests/integration/bootstrap.php" beStrictAboutOutputDuringTests="true" failOnWarning="true" colors="true" cacheDirectory=".phpunit.cache">
<phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/11.5/phpunit.xsd" bootstrap="tests/integration/bootstrap.php" beStrictAboutOutputDuringTests="true" failOnWarning="true" failOnNotice="true" colors="true" cacheDirectory=".phpunit.cache" displayDetailsOnTestsThatTriggerDeprecations="true" failOnDeprecation="true">
<testsuites>
<testsuite name="integration">
<directory>tests/integration</directory>
Expand All @@ -8,10 +8,13 @@
<php>
<env name="DATABASE_URL" value="sqlite://i@i/var/test.db"/>
<env name="KERNEL_CLASS" value="Ibexa\Tests\Integration\AdminUi\AdminUiIbexaTestKernel"/>
<env name="SYMFONY_DEPRECATIONS_HELPER" value="max[self]=0&amp;max[direct]=0&amp;verbose=0"/>
</php>
<extensions>
<bootstrap class="DAMA\DoctrineTestBundle\PHPUnit\PHPUnitExtension"/>
<bootstrap class="Symfony\Bridge\PhpUnit\SymfonyExtension"/>
</extensions>
<source baseline="phpunit.integration.baseline.xml" ignoreIndirectDeprecations="false" ignoreSuppressionOfDeprecations="true">
<include>
<directory>src</directory>
</include>
</source>
</phpunit>
7 changes: 2 additions & 5 deletions phpunit.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<?xml version="1.0"?>
<phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/11.5/phpunit.xsd" bootstrap="bootstrap.php" colors="true" cacheDirectory=".phpunit.cache">
<phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/11.5/phpunit.xsd" bootstrap="bootstrap.php" colors="true" cacheDirectory=".phpunit.cache" displayDetailsOnTestsThatTriggerDeprecations="true" failOnDeprecation="true" failOnWarning="true" failOnNotice="true">
<testsuites>
<testsuite name="Ibexa\Bundle\AdminUi">
<directory>tests/bundle</directory>
Expand All @@ -8,12 +8,9 @@
<directory>tests/lib</directory>
</testsuite>
</testsuites>
<source>
<source baseline="phpunit.baseline.xml" ignoreIndirectDeprecations="false" ignoreSuppressionOfDeprecations="true">
<include>
<directory>src</directory>
</include>
</source>
<extensions>
<bootstrap class="Symfony\Bridge\PhpUnit\SymfonyExtension"/>
</extensions>
</phpunit>
Loading