Conversation
…em buttons The global `a:active, a:focus, a:hover` rule is specificity (0,1,1) and outranks the single-class .ids-btn, so any design-system button rendered as an <a> lost its label colour once focused and no longer hovered. Scoped with :where(:not(.ids-btn)) to keep the original specificity while excluding DS buttons. Co-Authored-By: Claude <noreply@anthropic.com>
|
albozek
approved these changes
Sep 16, 2026
OstafinL
approved these changes
Sep 16, 2026
GrabowskiM
approved these changes
Sep 16, 2026
dew326
approved these changes
Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related PRs:
Description:
_general.scssstyles every anchor's:active/:focus/:hoverwith the primary purple. That selector is specificity (0,1,1), which outranks the design system's single-class.ids-btn(0,1,0). Since the DS only restates the button colour on:focus-visible(0,2,0), any DS button rendered as an<a>lost its label colour in one specific state: focused by mouse (so no:focus-visible) and no longer hovered (so.ids-btn:hoverdoesn't cover it either). The label fell through to the link purple.Scoped the rule with
:where(:not(.ids-btn)).:where()adds no specificity, so the rule keeps its original (0,1,1) weight for ordinary links and only stops matching design-system buttons.This is what made the product tour's "Done" button render purple instead of white (reported on IBX-12442). The matching workaround in integrated-help is removed in the linked PR.
Note the existing per-component workaround in
_main-menu.scss(&:focus { color: $ibexa-color-white }) is deliberately left in place: only 20 of 74.ibexa-main-menu__item-actionelements carryids-btn, the rest are plain second-level<a>links that still rely on the global rule.For QA:
Documentation:
🤖 Generated with Claude Code