IBX-12358: Bootstrapped integration tests through Bootstrapper - #2082
Merged
Merged
Conversation
tests/integration/bootstrap.php hand-rolled the pre-IBX-12358 flow: boot the kernel, drop and create the database, loop getSchemaFiles() through LegacySchemaImporter, loop getFixtures(). Adopting Bootstrapper needed ibexa/test-core off 0.1.x-dev first, since that line predates it. ibexa/test-rest had to move with it — it requires ~0.1.x-dev of test-core, so bumping one alone does not resolve. Both go to ~4.6.x-dev. Bootstrapper runs doctrine:schema:update by default and this bootstrap never did, so OPTION_SCHEMA_UPDATE is switched off to keep the two equivalent. AdminUiIbexaTestKernel registers IbexaTestCoreBundle, which Bootstrapper requires.
|
Steveb-p
marked this pull request as ready for review
September 10, 2026 10:43
Steveb-p
added
Ready for review
Tests update
konradoboza
approved these changes
Sep 10, 2026
ibexa-workflow-automation-1
Bot
requested review from
ViniTou,
alongosz,
barw4,
bnowak,
ciastektk,
konradoboza,
mikadamczyk,
tbialcz and
wiewiurdp
and removed request for
a team
September 10, 2026 10:56
This was referenced Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related PRs:
Description:
tests/integration/bootstrap.phphand-rolls the pre-IBX-12358 flow — boot the kernel, drop andcreate the database, loop
getSchemaFiles()throughLegacySchemaImporter, loopgetFixtures().Bootstrapperdoes all of it.This needed a dependency bump first. This package was on
ibexa/test-core0.1.x-dev, whichpredates
Bootstrapper— the class simply is not in that line.ibexa/test-resthad to move withit, because it requires
~0.1.x-devof test-core, so bumping test-core alone does not resolve:Both go to
~4.6.x-dev. Despite the version jump this is a renumbering of the same line ratherthan five majors of drift, and nothing in this package needed adjusting for it — see QA.
Note this bootstrap never ran
doctrine:schema:update, andBootstrapperenables it by default, soOPTION_SCHEMA_UPDATE => falseis passed to keep the two equivalent.AdminUiIbexaTestKernelregistersIbexaTestCoreBundle, whichBootstrapperrequires.For QA:
Same checkout throughout, so the numbers are directly comparable:
composer test-integrationtest-core0.1.x-dev, hand-rolled bootstrap)BootstrapperAlso green:
composer phpstan,composer check-cs.