Repository navigation
fix(deepseek_v41): use std::numbers::pi, which MSVC defines - #141
Merged
Merged
Conversation
13thblade
added a commit
to 13thblade/ninfer-all-nvfp4
that referenced
this pull request
Oct 25, 2026
Ten commits upstream since b3402a6, 33 files and 922/176 lines. Four are substantive: 7cf5b2a fixes the M_PI build break in deepseek_v41 with std::numbers::pi (PR iamwavecut#141), 710df20 reports the release tag as the version, 3f2b59c prefetches prompt spans' expert banks and keeps the lent slots a call reads, and 6ab3e66 prefills DeepSeek prompts block by block in spans. The rest are docs (What's New, DeepSeek across cards, one-host Strata comparison) and three merge commits. Two of those files overlap the fork's own change set. README.md merged on its own: the fork's head stays byte-identical and everything from the mirror marker on is upstream's README at a53a4f3 verbatim. src/models/deepseek_v41/executor.cpp conflicted, on the one expression the fork patched in 03b78d6. Upstream fixed the same defect, more idiomatically: the standard C++20 constant plus its own include, where the fork had introduced a local kPi. The merge takes upstream's side and the fork's fix retires with it; the staged blob is upstream's 44e4c04, so the fork no longer modifies that file at all. The two review branches were rebased onto a53a4f3 in the same pass: pr/nvfp4-w4a16 = b76d912 and pr/nvfp4-w4a8-int = 5dc9e11, both with the same patch-id as before the sync and the same diffstats (73 files 1356/257 and 96 files 6939/98), so nothing of either nvfp4 commit moved. Not rebuilt or re-gated here, deliberately: none of the ten commits touch a file the fork changes, and the only conflict resolved to upstream's own fix. The last gated build (61 passed, 2 skipped) still describes the nvfp4 code. Note that the build tree now trails master: 3f2b59c's expert delivery fix and 6ab3e66 are in master but not in the binaries, which matters before any host- or disk-resident expert measurement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Master's MSVC host-code checks and the Windows native release failed on
src/models/deepseek_v41/executor.cpp: MSVC definesM_PIonly with_USE_MATH_DEFINES, so the YaRN correction range did not compile (C2065, then C2665/C2737 from the lambda that lost its type). The C++20 constantstd::numbers::pihas the same double value. The check had reported 377 of 378 translation units compiling; this was the only failure.