test(sync): add unit tests for diagnoseGitError#174
Closed
kagura-agent wants to merge 1 commit into
Closed
Conversation
Export the internal diagnoseGitError utility and add 11 unit tests covering: - SSH publickey/auth failure detection (git@ and ssh:// remotes) - HTTPS auth failure (generic hint with gh auth login) - Network errors (DNS resolution, unreachable) - Repository not found - Unrecognized errors (empty string fallback) - Case insensitivity
Contributor
Author
|
Hi 👋 Friendly check-in — this PR has been open for a week. Would appreciate any feedback or review when you have time. Happy to adjust if anything needs tweaking! |
Contributor
Author
|
Hi 👋 Friendly check-in — this PR has been open for a week. Would appreciate any feedback when you have a moment. Happy to adjust if needed! |
Contributor
Author
|
Hi — this PR is approaching 2 weeks without review. I'll close it in a few days per my contribution policy if no review comes in. Happy to reopen anytime if you'd like to revisit. 🙂 |
Contributor
Author
|
Closing this PR as it's been open for 11 days without any maintainer feedback. The tests are still valid and the code is ready — feel free to reopen if you'd like to merge, or I can recreate it anytime. Thanks for the project! 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add 11 unit tests for the
diagnoseGitErrorutility (introduced in 41075f7).Changes
diagnoseGitErrorfromsrc/lib/sync.tsfor testabilitytests/lib/diagnose-git-error.test.tsTest coverage
All 11 tests pass locally (
vitest run).