fix: await locale manifest write - #3199
Open
OskarEichler wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking/build behavior changes
locale.jsonto be written before completing.Problem
listLocaleJsonstartedpromisifyWriteFile(...)without awaiting or returning it. The build could complete before the manifest was durable, while write failures escaped as unhandled promise rejections.Fix
Await the locale manifest write inside the existing async helper.
The regression test injects a failed write and verifies that the exact error reaches the build's error handler.
Verification
npm test— 94 suites, 795 tests passednpm run lintNODE_OPTIONS=--openssl-legacy-provider npm run buildgit diff --check