fix(minMax): select dates in one pass without temporary arrays - #3191
Open
OskarEichler wants to merge 1 commit into
Open
fix(minMax): select dates in one pass without temporary arrays#3191OskarEichler wants to merge 1 commit into
OskarEichler wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes and simplification
nullconsistently when every supplied value is absent. Previouslydayjs.max([null, undefined])returnedundefined, whiledayjs.max([])returnednull.Valid result identity, first-winner tie handling, ignored falsy entries, and invalid-date propagation are preserved. Input arrays are not mutated. This builds on the null-skipping behavior introduced in #2330.
Compatibility
No new API, types, dependencies, or runtime requirements. The observable correction is
nullinstead ofundefinedfor all-absent input; callers explicitly distinguishing those values should account for it. Invalid Day.js objects are still propagated, not silently ignored.Verification
No tests were added or changed. Legacy size checking used a process-local OpenSSL compatibility flag on Node 22, not a package change.