fix(calendar): honor the Unix epoch as a reference time - #3190
Open
OskarEichler wants to merge 1 commit into
Open
fix(calendar): honor the Unix epoch as a reference time#3190OskarEichler wants to merge 1 commit into
OskarEichler wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
Honor numeric Unix timestamp
0as the calendar reference. It was previously treated as an omitted reference and replaced with the current date.Compatibility
No breaking API, dependency, or runtime changes. Only the incorrect numeric-zero reference changes. Existing omitted/null/falsy fallback behavior is preserved, and calendar callbacks still receive the current time as documented—not the supplied reference. Formatting, locale selection, and category thresholds are unchanged.
Verification
No tests were added or modified. The legacy size checker required a process-local OpenSSL legacy-provider flag on Node 22; no package configuration change was made.