fix(plugin): keep utc mode when customParseFormat gets a format array - #3185
Open
official-burak wants to merge 1 commit into
Open
fix(plugin): keep utc mode when customParseFormat gets a format array#3185official-burak wants to merge 1 commit into
official-burak wants to merge 1 commit into
Conversation
Array formats were re-parsed through dayjs(), which drops cfg.utc and reads the date in local time. Reconstruct with the original utc flag so dayjs.utc(input, [...]) matches a single format string.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3013
dayjs.utc(input, 'YYYY-MM-DD')parses in UTC, butdayjs.utc(input, ['YYYY-MM-DD', 'YYYY-M-D'])was going throughdayjs(), which dropscfg.utcand builds a localDate. On a non-UTC host that silently shifts the instant (the issue's example: local midnight instead of1995-05-01T00:00:00.000Z).The array loop now constructs with the original
utcflag so each candidate format uses the same path as a single format string.Test
Added in
test/plugin/utc.test.js. Failed onTZ=America/New_Yorkbefore the change (1995-05-01T04:00:00Z), passed after. ExistingcustomParseFormatarray-format tests still pass.