fix: keep calendar date when subtracting years across historical TZ change - #3175
Open
arronKler wants to merge 1 commit into
Open
fix: keep calendar date when subtracting years across historical TZ change#3175arronKler wants to merge 1 commit into
arronKler wants to merge 1 commit into
Conversation
…hange
daysInMonth() used endOf('month'), which builds local 23:59:59.999.
In Asia/Kuala_Lumpur that instant jumps across the 1981-12-31 UTC+7:30
to UTC+8 change, so the day becomes 1 and year/month set clamps to Dec 1.
Use the UTC calendar month length instead.
Fixes iamkun#3137
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
subtract(100, 'years')on2081-12-25inAsia/Kuala_Lumpurreturned1981-12-01instead of1981-12-25.Year/month
setclamps the day withdaysInMonth(), which usedendOf('month'). That builds local23:59:59.999, and Malaysia’s 1981-12-31 midnight jump (UTC+7:30→UTC+8) moves that instant onto1982-01-01, sodaysInMonth()becomes1.daysInMonth()now uses the UTC calendar month length, which is independent of that local last-millisecond construction.Fixes #3137