fix(build): sort locale metadata deterministically - #3171
Open
irosadie wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
🟢 Ready to approve
The change is small, localized to build output generation, and deterministically sorts the locale list while properly awaiting the file write.
This review doesn't count toward merge requirements. Sign up for the private preview to control whether Copilot approvals count.
Pull request overview
This PR updates the build script that generates locale.json so locale metadata is written in a deterministic order, making the build output reproducible regardless of filesystem enumeration order.
Changes:
- Sort the generated locale metadata array by locale key before serializing to JSON.
- Await the
writeFileoperation to ensurelocale.jsonis fully written before the build script continues/exits.
File summaries
| File | Description |
|---|---|
| build/index.js | Sorts locale entries deterministically and awaits the write to make locale.json generation reproducible. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3163
Sort locale metadata by locale key before writing
locale.json.This makes the generated locale list independent of filesystem enumeration order and keeps build output reproducible.
Validation:
npm run lintNODE_OPTIONS=--openssl-legacy-provider npm run build