Conversation
except TypeError, ValueError: is Python 2 syntax and raises a SyntaxError in Python 3 at import time, breaking the whole grocy_data module (and therefore the entire integration) as soon as it is (re)loaded. Introduced alongside the STOCK_DUE_SOON_DAYS lowercase-fallback handling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
custom_components/grocy/grocy_data.pyline 129 uses Python 2 exception syntax:This is invalid in Python 3 and raises a
SyntaxErrorwhen the module is compiled/imported:Because this is a module-level compile error, it breaks the import of
grocy_data.pyentirely, which breaks setup of the whole Grocy integration as soon as Home Assistant (re)loads it - not just theSTOCK_DUE_SOON_DAYScode path thisexceptbelongs to.This looks like it was introduced together with the
STOCK_DUE_SOON_DAYS/stock_due_soon_dayslowercase-fallback handling inasync_get_config(related to #44 / #45).Fix
Parenthesize the exception tuple, as required by Python 3:
Testing
python3 -c "import ast; ast.parse(open('custom_components/grocy/grocy_data.py').read())"now succeeds (previously raised theSyntaxErrorabove).