fix: drop duplicate trace button on strand detail (v0.3.8)#25
Merged
Conversation
… (v0.3.8) v0.3.7 wired plugin_right_page into strand.html, which made the StrandTraceButton PluginTemplateExtension fire and render the trace button. The template also kept the pre-v0.3.1 inline include of the button as a workaround, so the button rendered twice. Removed the inline include + updated the extension's docstring.
The {# #} short comment is single-line only. My multi-line comment
about the trace button leaked subsequent lines into template
content, including a bare {% plugin_right_page %} call which Django
parsed as an actual tag invocation missing its obj argument — hence
the CI test failure 'plugin_right_page did not receive value for obj'.
Wrapped with {% comment %}{% endcomment %} block tags.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1-line template fix. After v0.3.7 wired the plugin slots, the 'Trace this core' button rendered twice on strand detail (inline include + PluginTemplateExtension both fired). Removed the inline include; extension is now the single source of truth.