fix: Brown badge + strand template polish (v0.3.7)#24
Merged
Conversation
NetBox's badge palette doesn't include 'brown' as a recognised colour, so .badge.text-bg-brown fell through to the default dark surface and was unreadable. Override with #8b4513 (saddle brown) so TIA-598 position 4 looks like a brown fibre. CSS-only one-line addition. Spotted during the v0.3.5 visual self-audit.
…slots (v0.3.7)
Three audit findings bundled into v0.3.7 (was going to be v0.3.6
Brown-only):
1. Brown badge CSS override (saddle brown #8b4513) - already on branch
2. strand.html line 19: {% badge object.get_color_display %} didn't
pass bg_color, so even with v0.3.5's get_color_color() helper the
detail page Colour rendered as grey. Now passes
bg_color=object.get_color_color and matches list-view fidelity.
3. strand.html + trunkbreakout.html were missed in v0.3.1's plugin-
slot pass; now load {% load plugins %} and render
plugin_left_page / plugin_right_page / plugin_full_width_page so
Attachments / Documents / other plugin cards appear on these
pages too.
All spotted during the v0.3.5 visual self-audit on CT 109.
iamjohnnymac
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bundled v0.3.7 from audit findings: