fix: readable FibreLink loss-budget gauge (v0.3.3)#21
Merged
Conversation
Prior gauge inlined the numeric readout INSIDE the SVG at font-size 5.5 viewBox units with a near-black fill (#1a1a1a). On NetBox's dark theme the text was essentially invisible. Fixed: numbers move out of the SVG into bold HTML text + a coloured Bootstrap badge for the percent (text-bg-success/warning/danger matching the band). SVG is now a pure visual bar — full container width, 18px tall, no embedded text. Short legend underneath. Long-standing UX bug spotted during the v0.3.x Chrome walkthrough.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gauge text was unreadable on dark theme (font-size 5.5 viewBox units, near-black fill). Moved numeric readout + percent badge out of the SVG; SVG is now a clean visual bar. One-file template change. Found during the live-verify on CT 109.