Repository navigation
Review follow-ups: scrub share snippets, sync guard, a11y polish - #3
Merged
Merged
Conversation
Code - build_share_snippet now scrubs /Users and /home paths and inline ISO timestamps from the audit body; docstring rewritten to match. - Share snippet renders through rich.Markdown in the CLI, matching the main audit output. - Three new tests: path scrubbing, timestamp scrubbing, and a CliRunner smoke test for `vera audit --share`. CI - New .github/scripts/check_prompt_sync.py: diffs PROMPT.md's fenced block against the const PROMPT literal in docs/index.html. Wire into CI in a follow-up commit. Landing page - rel="noopener" -> rel="noopener noreferrer" on all external links. - Inline SVG favicon (data URI, no asset file). - Visually hidden role="status" aria-live node wired to the copy flow so screen readers announce copy success/failure. Shell - launch/ship.sh now drops `pip install --user` when inside a venv. Docs - examples/README notes audit.share.md is a one-time snapshot.
- cancel-in-progress on same ref so successive pushes don't queue duplicate runs - new prompt-sync job runs .github/scripts/check_prompt_sync.py, failing CI if PROMPT.md diverges from the embedded literal in docs/index.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Retrospective fixes from the review of PR #1 + PR #2.
Code
build_share_snippetnow scrubs/Users/...+/home/...paths and inline ISO timestamps from the audit body; docstring rewritten to match behaviour.rich.Markdownin the CLI, matching the main audit output.CliRunnersmoke test forvera audit --share. All 24 tests pass; wheel + sdist still passtwine check.CI guard
.github/scripts/check_prompt_sync.pydiffs the fenced block ofPROMPT.mdagainst theconst PROMPT = \…`literal indocs/index.htmland fails on drift. **Wiring intoci.ymlis a follow-up commit** — this token lacks theworkflow` scope, so the job add needs to be pushed manually (see below).Landing page (
docs/index.html)rel="noopener"→rel="noopener noreferrer"on all external links.<span role="status" aria-live="polite">wired to the copy flow so screen readers announce success/failure.Shell (
launch/ship.sh)pip install --userwhen running inside a venv (detectsVIRTUAL_ENVorsys.prefix != sys.base_prefix).Docs (
examples/README.md)audit.share.mdis a one-time snapshot.Pending local commit
ci.ymladditions (concurrency group +prompt-syncjob wiring the script above) are stashed locally. To land them:```
git checkout followup-review-fixes
gh auth refresh -s workflow
git stash pop
git add .github/workflows/ci.yml
git commit -m "CI: concurrency + prompt-sync job"
git push
```
Test plan
🤖 Generated with Claude Code