Repository navigation
feat: add --no-dnssec to skip DNSSEC checks and penalties - #14
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolvers without confirmed DNSSEC validation currently receive a ranking penalty, with no dedicated flag to opt out. Add
--no-dnssectorunandprobeto skip the DNSSEC checks. Onrun, the flag also removes the DNSSEC penalty from every ranking mode, overriding custom weights while retaining other checks and penalties.Terminal, HTML, TXT and JSON reports distinguish skipped DNSSEC checks from unknown or failed validation. CSV exports append a
dnssec_validationcolumn without moving existing columns. Update the README and methodology, formula and architecture documentation, and bump dnsbench from0.7.1to0.8.0for this feature.Validation:
go test ./...passed for the feature, including coverage for skipped queries, transport failures, custom-weight overrides, preserved non-DNSSEC penalties and report exports. After the version bump,go run ./cmd/dnsbench --versionreturneddnsbench version 0.8.0.