Skip to content

feat: Add enhanced table functionality#130

Open
msoukhomlinov wants to merge 7 commits into
iainbrighton:devfrom
msoukhomlinov:feature/table-enhancements
Open

feat: Add enhanced table functionality#130
msoukhomlinov wants to merge 7 commits into
iainbrighton:devfrom
msoukhomlinov:feature/table-enhancements

Conversation

@msoukhomlinov

Copy link
Copy Markdown

Added new features for improved table handling:

  • Write-EnhancedTable function for automatic column width calculation
  • Empty column detection and removal capabilities
  • Custom column width distribution
  • Get-TableEmptyColumn for analyzing empty columns
  • Comprehensive test coverage for all new functions
  • Example45.ps1 demonstrating enhanced table features
  • Added localized messages for enhanced table operations
  • New about_PScriboEnhancedTables.help.txt documentation

Added new features for improved table handling: - Write-EnhancedTable function for automatic column width calculation - Empty column detection and removal capabilities - Custom column width distribution - Get-TableEmptyColumn for analyzing empty columns - Comprehensive test coverage for all new functions - Example45.ps1 demonstrating enhanced table features - Added localized messages for enhanced table operations - New about_PScriboEnhancedTables.help.txt documentation
- Fixed document context initialization in tests

- Fixed array handling using Measure-Object

- Added support for objects with no properties

- Fixed empty string value handling

- Fixed array conversion and property counting

- Added localization strings for new messages

- All tests now passing
- Fix input validation in Find-EmptyTableColumn for string inputs
- Update error message format in Get-TableColumnWidth
- Improve custom width handling and validation
- Add proper type checking and error handling
- Fix all unit tests (329/329 passing)
@msoukhomlinov

Copy link
Copy Markdown
Author

@iainbrighton , could you please take a look at this?

@iainbrighton

Copy link
Copy Markdown
Owner

Thanks @msoukhomlinov for the contribution. It looks comprehensive and I will take a more detailed look. Apologies for the slow response, but I have been putting off updating the release pipelines to support the new HSM certificate requirements. I can't release any new code until this is done 😢.

I have had a quick glance over the code and can see that it is a wrapper around the existing Table functionality. Do you think your work should ultimately be moved/merged into the default Table functionality? It would make sense to have only one table implementation but I am interested to hear others' thoughts on this.

Cheers,
Iain

@msoukhomlinov

msoukhomlinov commented Mar 4, 2025

Copy link
Copy Markdown
Author

Thanks @msoukhomlinov for the contribution. It looks comprehensive and I will take a more detailed look. Apologies for the slow response, but I have been putting off updating the release pipelines to support the new HSM certificate requirements. I can't release any new code until this is done 😢.

I have had a quick glance over the code and can see that it is a wrapper around the existing Table functionality. Do you think your work should ultimately be moved/merged into the default Table functionality? It would make sense to have only one table implementation but I am interested to hear others' thoughts on this.

Cheers, Iain

Hi @iainbrighton , its up to you, maybe this may over-complicate existing table implementation, I'd be guided by your thoughts.

@msoukhomlinov

Copy link
Copy Markdown
Author

Hi @iainbrighton , a gentle reminder re this, would like to close this out.

@msoukhomlinov

Copy link
Copy Markdown
Author

@iainbrighton , a gentle reminder please.

@rebelinux

Copy link
Copy Markdown

I want to test this features!

do the branch have the latest 0.11.1 changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants