Fix ESLint config and unblock production build#1
Open
Dawittekle wants to merge 4 commits intoiCog-Labs-Dev:mainfrom
Open
Fix ESLint config and unblock production build#1Dawittekle wants to merge 4 commits intoiCog-Labs-Dev:mainfrom
Dawittekle wants to merge 4 commits intoiCog-Labs-Dev:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR restores a working lint/build pipeline for the frontend.
What changed
Why this was needed
After fixing the ESLint config, the real build blockers were
react-hooks/rules-of-hookserrors.The blocking patterns were mainly:
Some larger-looking refactors in this PR were still required, because those hook-rule violations were present in table action cells and waveform preview cells across several screens.
Verification
Ran locally:
corepack pnpm lintcorepack pnpm buildBoth pass.