fix(devices): correct desktop icon relative path for Desktop install location#54
Merged
Merged
Conversation
…location - devices/FlowBase.desktop: update Icon path to ../i2rt/i2rt/flow_base/assets/flow_base.png so it resolves from /home/i2rt/Desktop to the repo at /home/i2rt/i2rt - devices/FlowBaseGamepad.desktop: same Icon path correction - devices/LinearRailVehicle.desktop: update Icon path to ../i2rt/i2rt/flow_base/assets/linear_rail.png for the new install location - devices/LinearRailVehicleGamepad.desktop: same Icon path correction Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
.desktoplauncher files install to/home/i2rt/Desktopwhile the repo is cloned to/home/i2rt/i2rt. TheIcon=paths were relative to the file's in-repo location (devices/), so they broke once the files were copied to the Desktop. This corrects the relativeIcon=paths to resolve from/home/i2rt/Desktopto the icon assets in the repo.Changes
Icon=to../i2rt/i2rt/flow_base/assets/flow_base.pngso it resolves from/home/i2rt/Desktopto/home/i2rt/i2rt/i2rt/flow_base/assets/flow_base.pngIcon=path correction (flow_base.png)Icon=to../i2rt/i2rt/flow_base/assets/linear_rail.pngfor the new install locationIcon=path correction (linear_rail.png)Test Plan
/home/i2rt/i2rtand copy the four files fromdevices/into/home/i2rt/Desktop./home/i2rt/i2rt/i2rt/flow_base/assets/flow_base.pngandlinear_rail.pngexist./home/i2rt/Desktop, runreadlink -f ../i2rt/i2rt/flow_base/assets/flow_base.pngand verify it resolves to the file above.Icon=paths, note that absolute paths may be required (per-spec,Icon=expects an absolute path or a bare theme name).🤖 Generated with Claude Code