ldap: remove escape characters from search DN#22
Open
seanhoughton wants to merge 1 commit intoi-core:masterfrom
Open
ldap: remove escape characters from search DN#22seanhoughton wants to merge 1 commit intoi-core:masterfrom
seanhoughton wants to merge 1 commit intoi-core:masterfrom
Conversation
Names in "last, first" format end up with a backslash escape character which breaks searches
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Names in "last, first" format end up with a backslash escape character which breaks searches
Proposed Changes
There may be a better way to deal with this problem but I don't have enough experience with the LDAP modules to understand how and when values include escape values. It seems strange that the escape character makes it into the response but it seems to.