-
Notifications
You must be signed in to change notification settings - Fork 139
feat: deepagents content creator example port #1942
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Tomas Dvorak <toomas2d@gmail.com>
Signed-off-by: Tomas Dvorak <toomas2d@gmail.com>
Summary of ChangesHello @Tomas2D, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request adds a sophisticated content creation agent built on the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a new deepagents_content_creator agent example. The implementation is comprehensive, including the agent logic, Docker configuration, and detailed documentation in markdown files for agent skills and memory. However, there are several critical issues that need to be addressed. The Dockerfile has an incorrect working directory, there are several incorrect file paths in the agent code, and a bug in how LLM demands are created. The README is also heavily inconsistent with the actual implementation, which will make it very difficult for users to run this example. Additionally, there's a critical error in the mise.lock file that will break the development environment for macOS users. I've provided specific comments and suggestions for each of these issues.
agents/deepagents_content_creator/src/content_creator/backend.py
Outdated
Show resolved
Hide resolved
agents/deepagents_content_creator/src/content_creator/skills/blog-post/SKILL.md
Show resolved
Hide resolved
agents/deepagents_content_creator/src/content_creator/skills/social-media/SKILL.md
Show resolved
Hide resolved
Signed-off-by: Tomas Dvorak <toomas2d@gmail.com>
Signed-off-by: Tomas Dvorak <toomas2d@gmail.com>
Signed-off-by: Tomas Dvorak <toomas2d@gmail.com>
Signed-off-by: Tomas Dvorak <toomas2d@gmail.com>
Signed-off-by: Tomáš Dvořák <toomas2d@gmail.com>
Summary
Adds Content Builder (Creator) Agent example from https://github.com/langchain-ai/deepagents/tree/master/examples/content-builder-agent (Deepagents), ported to AgentStack with the following features:
modelattribute insubagents.yamluses LLM Service ExtensionFilecomponent to "save" files instead of built-in Python functionalities. Changes are then sent to the UI (FilePart).In order to simplify the "porting" process, we need to introduce the following primitives:
Linked Issues
Ref: #1808
Documentation
If this PR adds new feature or changes existing. Make sure documentation is adjusted accordingly. If the docs is not needed, please explain why.