Skip to content

Conversation

@tomkis
Copy link
Collaborator

@tomkis tomkis commented Jan 28, 2026

Summary

Support to handle non-streaming agents via Message.

Linked Issues

Fixes #1877

Documentation

  • No Docs Needed:

Fixes a bug in how non-streaming is handled.

Signed-off-by: Tomas Weiss <tomas.weiss2@gmail.com>
@tomkis tomkis requested review from PetrBulanek and kapetr January 28, 2026 14:25
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jan 28, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @tomkis, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves an issue where non-streaming agent messages were not being properly processed. It enhances the client-side message handling to correctly interpret and display responses from agents that do not stream their output, ensuring a consistent user experience regardless of the agent's streaming capabilities.

Highlights

  • Non-Streaming Message Handling: Introduced a new case within the event processing logic to specifically handle messages of kind: 'message'. This ensures that non-streaming agent responses are correctly parsed, their task IDs resolved, and their metadata and content parts are combined and emitted.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for non-streaming agents by handling the message event. The implementation correctly processes message parts and forwards them. My main feedback is regarding the logic for determining the task ID, which falls back to using the message ID. This could be a bit confusing and has potential side effects. I've added a specific comment with a suggestion to improve clarity by adding a comment.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 28, 2026
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: Tomáš Weiss <tomas.weiss2@gmail.com>
@tomkis tomkis removed the request for review from kapetr January 30, 2026 07:57
@tomkis tomkis merged commit 4df0fef into main Jan 30, 2026
8 checks passed
@tomkis tomkis deleted the fix/1877-non-streaming-agents branch January 30, 2026 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

UI: non-streaming agents show 'Message has no content'

3 participants