Conversation
Atraxus
force-pushed
the
master
branch
2 times, most recently
from
September 16, 2026 15:43
61299ba to
67bb03c
Compare
Atraxus
marked this pull request as ready for review
September 22, 2026 13:51
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Fixes a memory corruption in non-sequential tracing: the source event took slot 0, then the hit loop stored at hitIndex + 1 over [0, maxEvents), so a ray still hitting elements at the end wrote one event past its allotment into the neighbouring attribute buffer. This affects any non-sequential trace where a ray reaches the event ceiling — on UE112 it corrupted two events and aborted the CSV writer mid-file. Elements now get maxEvents - 1 with the source slot reserved. Also includes three independent fixes found along the way — ElementTypeToString missing Undefined and RayListSource (throws under --verbose on ray-list beamlines, now with a Count sentinel and round-trip test), a missing else in ObjectMask::setShouldRecordObject, and the UI aborting with element id: -1 when opening CLI-traced files — plus a clang-format pass and a docs note recording 19 as the reference version. 130/130 tests; every commit builds and is format-clean.
Addition: Fix for the rotation of the paraboloid added, which was not applied correctly before. This now follows what the ellipsoid and RAY-UI already did.
✅ Pre-Merge Checklist
Important
By requesting a review, you confirm this PR is complete from your side. Once approved, it may be merged by someone else. Both developers and reviewers must ensure the PR is truly ready for merge when all checks are green.
Please complete each item before requesting a review.
TODOComments (prefer new issues instead)masterif individual commits don’t add valuemaster)