Skip to content

Fix windows CI - #471

Merged
JonasTrenkler merged 3 commits into
hz-b:masterfrom
JonasTrenkler:fix-windows-ci
Jun 23, 2026
Merged

JonasTrenkler merged 3 commits into
hz-b:masterfrom
JonasTrenkler:fix-windows-ci

Conversation

@JonasTrenkler

@JonasTrenkler JonasTrenkler commented Jun 23, 2026 •

Copy link
Copy Markdown
Collaborator

Type of Change

  • Bug fix (non-breaking change, fixing an issue)
  • New feature: Dependabot for GitHub actions
  • Breaking change (fix or feature that causes existing functionality to not work as expected)
  • Documentation / Wiki update

Description

  • Fix the windows test CI
  • add Dependabot for GitHub actions

There were 2 issues:

  • Vulkan 1.3.275 is no longer available for download (removed after 2 years)
  • Since 2026-06-15 all windows-2025 runners are redirected to windows-2025-vs2026 which broke the CUDA installation, as it uses a hard-coded path for VS22.

Fixed by :

  • updating the used Vulkan version to 1.4.304.1 (already used by the release action), Vulkan SDKs should be backwards compatible
  • changing the runner to windows-2022 that still uses VS22

I tested a switch to VS26 here, but due to the following issues this is not possible right now:

  • CMAKE has issues detecting CUDA with VS2026, which was apparently fixed with CUDA 13.2.
  • Alpaka currently does not support that CUDA version, support for 13.3 is planned for Alpaka 2.2

Optional notes for reviewer:

  • This was only tested for the testWindows workflow, the release workflow was updated accordingly and should be closer to the test now
  • Switched to the lightweight setup-vulkan-sdk that release already used. This should only take a couple of MB instead of one huge download, but needs to be build therefore initially slower until cached in the main branch. This also simplifies the GLSL validator dependency. The smaller caches hopefully make room to cache other jobs in the future (needs to be changed in the other workflows as well)
  • Dependabot could be annoying, but it's limited to for GitHub actions, should run weekly and bundle updates into one PR. Added because a lot of our used actions are deprecated currently signaling that this should be review more regularly.

✅ Pre-Merge Checklist

Important

By requesting a review, you confirm this PR is complete from your side. Once approved, it may be merged by someone else. Both developers and reviewers must ensure the PR is truly ready for merge when all checks are green.

Please complete each item before requesting a review.

  • Code follows the project's coding standards
  • Unit tests for new functionality are added and pass
  • All existing tests pass
  • Resolved TODO Comments (prefer new issues instead)
  • Documentation, if applicable, including:
    • Doxygen comments for any new rayx-core API functions
    • Helpful inline comments where needed for clarity
    • Wiki pages, e.g. updated build instructions, new Element etc.
  • Commits:
    • Use clear and readable commit messages (e.g. Conventional commits)
    • Squash and rebase onto master if individual commits don’t add value
    • Ensure linear commit history (required by master)

Vulkan 1.3.275 is no longer available for download (removed after 2
years), SDKs are backwards compatible and the release workflow already
uses 1.4.304.1.
At this time this is the latest confirmed working one with the
corresponding action.
Switched to the lightweight setup-vulkan-sdk which should only take a
couple of MB instead of 1GB+, but needs to be build (is cached).
This also simplifies the GLSL validator dependency.
Add weekly scheduled check for github actions.
Opens a PR grouped for all actions, instead of one per dependency.
Since 2026-06-15 all windows-2025 runners are redirected to
windows-2025-vs2026 which broke the CUDA installation, as it uses a
hard-coded path.
The Jimver/cuda-toolkit action seems out of date so continue to use the
manual download for windows.
Testing indicates that CMAKE has issues detecting CUDA with VS2026,
which was fixed with CUDA 13.2.
This is currently not supported by Alpaka, therefore use VS2022.
The windows-2022 runner includes NSIS used for packaging on windows
therefore it has been removed from the release workflow.
@JonasTrenkler
JonasTrenkler merged commit 47a8a19 into hz-b:master Jun 23, 2026
10 checks passed
@JonasTrenkler
JonasTrenkler deleted the fix-windows-ci branch June 23, 2026 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant