Repository navigation
Fix windows CI - #471
Merged
Merged
Fix windows CI#471
Conversation
Vulkan 1.3.275 is no longer available for download (removed after 2 years), SDKs are backwards compatible and the release workflow already uses 1.4.304.1. At this time this is the latest confirmed working one with the corresponding action. Switched to the lightweight setup-vulkan-sdk which should only take a couple of MB instead of 1GB+, but needs to be build (is cached). This also simplifies the GLSL validator dependency.
Add weekly scheduled check for github actions. Opens a PR grouped for all actions, instead of one per dependency.
Since 2026-06-15 all windows-2025 runners are redirected to windows-2025-vs2026 which broke the CUDA installation, as it uses a hard-coded path. The Jimver/cuda-toolkit action seems out of date so continue to use the manual download for windows. Testing indicates that CMAKE has issues detecting CUDA with VS2026, which was fixed with CUDA 13.2. This is currently not supported by Alpaka, therefore use VS2022. The windows-2022 runner includes NSIS used for packaging on windows therefore it has been removed from the release workflow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
There were 2 issues:
windows-2025runners are redirected towindows-2025-vs2026which broke the CUDA installation, as it uses a hard-coded path for VS22.Fixed by :
I tested a switch to VS26 here, but due to the following issues this is not possible right now:
Optional notes for reviewer:
testWindowsworkflow, thereleaseworkflow was updated accordingly and should be closer to the test nowsetup-vulkan-sdkthat release already used. This should only take a couple of MB instead of one huge download, but needs to be build therefore initially slower until cached in the main branch. This also simplifies the GLSL validator dependency. The smaller caches hopefully make room to cache other jobs in the future (needs to be changed in the other workflows as well)✅ Pre-Merge Checklist
Important
By requesting a review, you confirm this PR is complete from your side. Once approved, it may be merged by someone else. Both developers and reviewers must ensure the PR is truly ready for merge when all checks are green.
Please complete each item before requesting a review.
TODOComments (prefer new issues instead)masterif individual commits don’t add valuemaster)