Skip to content

pam: delay auth init until grace period expires #1069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
deivi98 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

pam: delay auth init until grace period expires #1069

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions src/auth/Pam.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,20 @@ CPam::~CPam() {

void CPam::init() {
m_thread = std::thread([this]() {
// If a grace period is active, delay PAM initialisation until it expires.
// Without this, modules such as pam_u2f immediately issue a FIDO2 challenge
// and light up the security key even though the user can still unlock via
// mouse/keyboard movement during grace — leaving the key stuck waiting for a
// touch that is never needed.
const auto GRACE_END = g_pHyprlock->m_tGraceEnds;
if (GRACE_END > std::chrono::system_clock::now()) {
Log::logger->log(Log::INFO, "PAM: grace period active, delaying auth start until grace expires");
std::unique_lock<std::mutex> lk(m_sConversationState.inputMutex);
m_sConversationState.inputSubmittedCondition.wait_until(lk, GRACE_END, [this] {
return m_sConversationState.terminateRequested || g_pHyprlock->isFadingOutOrTerminating();
});
}

while (true) {
resetConversation();

Expand Down