Repository navigation
Conversation
Author
|
Closing as this MAX_VERIFY_RETRIES and RETRY_INTERVAL are dirty and shall not become part of the main code base. Hovewer, tha patch itself is fixing the root cause in my configuration of fingerprint device changing its device number on longer suspend. |
|
I'm confused. It fixes your issue but your closing the PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar fix as #1049 but more complex failing scenario.
Fingerprint session goes stale after suspend if the reader re-enumerates (e.g. USB power-cycles on longer sleeps). VerifyStart on the old proxy fails silently and fingerprint auth just stays dead until a password attempt forces a reclaim.
Fix: on wake, retry Claim/VerifyStart with backoff (500ms, 10 tries max), dropping the stale device proxy on failure so a fresh one gets fetched.
Not doing a forced VerifyStop+Release on every wake (when the reader didn't lose power a.k.a short suspend), since it hits a still-live verify session. Only tears down on actual failure.
Tested on Synaptics Prometheus (06cb:00bd), short + long suspend, both recover without password fallback.