Fix/makefile build ordering#87
Open
goyalpalak18 wants to merge 2 commits intohyphae:add-license-1from
Open
Conversation
Sony to Hyphae changes
Signed-off-by: goyalpalak18 <goyalpalak1806@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses a build failure that occurs when running
make buildon a clean environment or when using parallel execution (make -j).Currently, the
Makefiletreats sub-projects as independent targets, but they actually have strict compile-time dependencies (e.g.,apis-commonrequiresapis-bomto be installed first). Without enforcing this order, Maven fails to find the required artifacts in the local repository, causing the build to crash for new contributors.Changes made:
Makefile.build-apis-commonnow strictly depends onbuild-apis-bom.build-apis-main,build-apis-ccc,build-apis-log, andbuild-apis-webnow depend onbuild-apis-common.cleantarget: Removed duplicate entries forclean-apis-commonandclean-apis-bomin thecleancommand (Line 96), which were previously listed twice.Related Issue
Fixes #74