feat: Add Docker support for containerized deployment (#65)#77
Open
Nakshatra480 wants to merge 1 commit intohyphae:add-license-1from
Open
feat: Add Docker support for containerized deployment (#65)#77Nakshatra480 wants to merge 1 commit intohyphae:add-license-1from
Nakshatra480 wants to merge 1 commit intohyphae:add-license-1from
Conversation
Adds Dockerfile, docker-compose.yml, and entrypoint script for containerized deployment. Fixes Vert.x version for build compatibility. Signed-off-by: Nakshatra Sharma <nakshatra.sharma3012@gmail.com>
Author
|
@axmsoftware @AkarshSahlot added the feature, pls review the changes... thanks |
Contributor
AkarshSahlot
left a comment
AkarshSahlot
left a comment
There was a problem hiding this comment.
Thanks for the contribution @Nakshatra480! I've reviewed the changes where you added four new files.
@axmsoftware - Could you please review these changes when you have a chance, before merging?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #65
Added Docker support to make running APIS easier. Instead of manually installing Java, Python, MongoDB and building everything, you can now just run
docker-compose up.What's included:
How to test:
docker-compose up(takes ~7 mins first time)Test results:
Known issue (not related to this PR):
The Service Center page loads but the UI doesn't render. This is a pre-existing bug in the
apis-service_centerrepo where JavaScript files are served withtext/htmlMIME type instead ofapplication/javascript. The browser blocks them due to strict MIME checking. This happens with or without Docker - it's an upstream issue that should be fixed separately.Changes to apis-bom:
Had to roll back Vert.x from 4.4.6 to 3.9.16 because the GitHub repos (apis-ccc, apis-web, etc.) use older Vert.x APIs that were removed in v4. Without this fix, the Docker build fails with compilation errors.