fix: resolve apis-bom build failure, apis-bom:3.0.0 not found, JUnit version missing (fixes #74)#76
Open
Nakshatra480 wants to merge 1 commit intohyphae:add-license-1from
Conversation
…ing) Use apis-bom 3.4.1 so the BOM resolves from local repo and JUnit gets its version. Add fixes/apis-common-pom.xml and Makefile changes to apply it before building. Resolves hyphae#74. Signed-off-by: Nakshatra Sharma <nakshatra.sharma3012@gmail.com>
a9843ef to
297e433
Compare
Author
|
@axmsoftware @AkarshSahlot changes are ready, pls review it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #74: Build fails when Maven tries to pull
apis-bomduring build (apis-bom:3.0.0not found in Maven Central).Problem
apis-commonimportsjp.co.sony.csl.dcoes.apis:apis-bom:3.0.0via${project.version}, but that BOM is not in Maven Central (it is built and installed locally).junit:junithas no version and the build fails with'dependencies.dependency.version' for junit:junit:jar is missing.Solution
apis-bomversion3.4.1inapis-common'sdependencyManagementinstead of${project.version}(3.0.0), so the BOM resolved from the local repo matches the installedapis-bomand JUnit gets its version from the BOM.fixes/directory with the correctedapis-commonpom.xml.apis-common(newapply-apis-common-fixtarget).apis-bomandapis-commononly if the directory is missing, so repeated builds work.Changes
fixes/apis-common-pom.xml–apis-commonPOM withapis-bomversion set to3.4.1.Makefile– Clone-if-missing forapis-bom/apis-common,apply-apis-common-fixtarget, andbuild-apis-commonupdated to use it.Verification
make build-apis-bomthenmake build-apis-common(ormake build) completes successfully.apis-commontests pass (mvn clean installinapis-common/).Closes #74.