chore: fill or remove RSR template placeholders - #68
Conversation
openssf-compliance.yml fails when any of the thirteen files it checks
still contains a {{PLACEHOLDER}} token. This clears them.
Three kinds of change, no invention:
The "TEMPLATE INSTRUCTIONS (delete this block before publishing)" comment
is deleted. The template says to delete it, and it is where every legend
line lives -- so a large share of the reported tokens were the file
documenting its own placeholders, not real unfilled fields.
Tokens derivable from the repository are filled: owner and repo from the
git remote, project name, year, forge, main branch, contact email.
PGP and website lines are removed rather than filled, because nothing
true could go in them. https://github.com/<user>.gpg returns HTTP 200 for
every account; with no key uploaded the body is a stub reading "This user
hasnt uploaded any GPG keys". No key is published for either account
here, and commit signing in this estate is SSH, which is unrelated. Only
one repository in the estate has a domain, so {{WEBSITE}} likewise has no
correct value. The template sanctions this: "Optional: Remove sections
that dont apply (e.g. PGP if you dont use it)." A security policy telling
a researcher to encrypt to a key that does not exist is worse than one
that does not mention encryption.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Signed-off-by: Jonathan D.A. Jewell <6759885+hyperpolymath@users.noreply.github.com>
|
![gitar-bot[bot]](https://avatars.githubusercontent.com/in/827041?s=60&v=4){kind=small}
|
Note Automatic reviews are paused because your trial's included automatic processing has been used for this period. Upgrade now, or comment "Gitar review" to run a review anytime. CI failed: 4 CI job failures caused by configuration, tooling, and governance issues including an unresolved cache path, a banned ReScript file, missing pyproject.toml for Poetry, and an unpinned GitHub action.OverviewMultiple distinct configuration, tooling, and governance checks failed across 4 CI jobs. All failures are directly related to the repository structure or workflow configuration. FailuresGitHub Actions Cache Path Unresolved (confidence: high)
Hypatia Governance Banned Language File (confidence: high)
Poetry Missing pyproject.toml (confidence: high)
Unpinned GitHub Action (confidence: high)
Summary
Code Review ✅ Approved 5 resolved / 5 findingsRemoves template placeholders across documentation files to satisfy openssf-compliance.yml, but leaves CONTRIBUTING.md truncated, CODE_OF_CONDUCT.md with unremoved instructions, and introduces metadata mismatches in guix.scm. ✅ 5 resolved✅ Bug: guix.scm describes squisher-corpus in social-media-polygraph repo
✅ Quality: CONTRIBUTING.md is truncated and malformed
✅ Bug: guix.scm license constructor likely called with wrong arity
✅ Quality: CODE_OF_CONDUCT.md still contains TEMPLATE INSTRUCTIONS block
✅ Quality: SECURITY.md retains PGP section with unfilled 'TBD' fingerprint
Tip Comment OptionsDisplay: compact → Showing less information. Comment with these commands to change the behavior for this request:
Was this helpful? React with 👍 / 👎 | Gitar |
1 participant
openssf-compliance.ymlfails when any of the thirteen files it checks still contains a{{PLACEHOLDER}}token. This clears them, with no invention.TEMPLATE INSTRUCTIONS (delete this block before publishing)comment — the template says to delete it, and it is where every legend line lived, so a large share of the reported tokens were the file documenting its own placeholders.https://github.com/<user>.gpgreturns HTTP 200 for every account; with no key uploaded the body is a stub reading "This user hasn't uploaded any GPG keys". No key is published for either account, and commit signing here is SSH — unrelated. The template sanctions this: "Optional: Remove sections that don't apply (e.g. PGP if you don't use it)."\n\nA security policy telling a researcher to encrypt to a key that does not exist is worse than one that does not mention encryption.\n\nWhere applicable, this also fixes a misrouted advisory URL. A previousjust initcopied already-filled templates out ofsquisher-corpus, so 51 repositories directed vulnerability reports tohyperpolymath/squisher-corpus— a repository unrelated to the code being reported, meaning the affected maintainer never saw them. Repointed from this repository's own git remote.