chore: fill or remove RSR template placeholders - #49
Conversation
openssf-compliance.yml fails when any of the thirteen files it checks
still contains a {{PLACEHOLDER}} token. This clears them.
Three kinds of change, no invention:
The "TEMPLATE INSTRUCTIONS (delete this block before publishing)" comment
is deleted. The template says to delete it, and it is where every legend
line lives -- so a large share of the reported tokens were the file
documenting its own placeholders, not real unfilled fields.
Tokens derivable from the repository are filled: owner and repo from the
git remote, project name, year, forge, main branch, contact email.
PGP and website lines are removed rather than filled, because nothing
true could go in them. https://github.com/<user>.gpg returns HTTP 200 for
every account; with no key uploaded the body is a stub reading "This user
hasnt uploaded any GPG keys". No key is published for either account
here, and commit signing in this estate is SSH, which is unrelated. Only
one repository in the estate has a domain, so {{WEBSITE}} likewise has no
correct value. The template sanctions this: "Optional: Remove sections
that dont apply (e.g. PGP if you dont use it)." A security policy telling
a researcher to encrypt to a key that does not exist is worse than one
that does not mention encryption.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Signed-off-by: Jonathan D.A. Jewell <6759885+hyperpolymath@users.noreply.github.com>
|
Note Automatic reviews are paused because your trial's included automatic processing has been used for this period. Upgrade now, or comment "Gitar review" to run a review anytime. CI failed: GitHub Actions workflow failed due to an unresolvable commit SHA for the CodeQL action introduced in this PR.OverviewAll analyzed CI logs failed due to a configuration error in the GitHub Actions workflow where an invalid or non-existent commit SHA was specified for a CodeQL action. FailuresUnresolvable CodeQL Action SHA (confidence: high)
Summary
Code Review 👍 Approved with suggestions 2 resolved / 3 findingsFills RSR template placeholders, updates Guix package metadata, and pins CodeQL actions, but the Guix package is mislabeled as squisher-corpus, its license conflicts with the SPDX header, and SECURITY.md still contains an unresolved PGP placeholder. 💡 Quality: SECURITY.md still contains unresolved PGP placeholderThe PR summary states PGP lines were removed, but SECURITY.md still advertises Encrypted Email with ✅ 2 resolved✅ Bug: guix.scm mislabels cccp package as squisher-corpus
✅ Quality: guix.scm license conflicts with SPDX header
🤖 Prompt for agentsTip Comment OptionsDisplay: compact → Showing less information. Comment with these commands to change the behavior for this request:
Was this helpful? React with 👍 / 👎 | Gitar |
openssf-compliance.ymlfails when any of the thirteen files it checks still contains a{{PLACEHOLDER}}token. This clears them, with no invention.TEMPLATE INSTRUCTIONS (delete this block before publishing)comment — the template says to delete it, and it is where every legend line lived, so a large share of the reported tokens were the file documenting its own placeholders.https://github.com/<user>.gpgreturns HTTP 200 for every account; with no key uploaded the body is a stub reading "This user hasn't uploaded any GPG keys". No key is published for either account, and commit signing here is SSH — unrelated. The template sanctions this: "Optional: Remove sections that don't apply (e.g. PGP if you don't use it)."\n\nA security policy telling a researcher to encrypt to a key that does not exist is worse than one that does not mention encryption.\n\nWhere applicable, this also fixes a misrouted advisory URL. A previousjust initcopied already-filled templates out ofsquisher-corpus, so 51 repositories directed vulnerability reports tohyperpolymath/squisher-corpus— a repository unrelated to the code being reported, meaning the affected maintainer never saw them. Repointed from this repository's own git remote.Summary by Gitar
guix.scmmetadata referencingsquisher-corpusand licensePMPL-1.0-or-later29b1f65cand addedactions: readpermission across workflowsGOVERNANCE.adocfile, retainingGOVERNANCE.mdThis will update automatically on new commits.