fix: finish the cartridges/ retirement — stop six more things passing over an empty set

[hyperpolymath]

The audit behind #306 found the cartridges/ retirement was roughly 70% done. This finishes the consumers.

The recurring defect is the same one #306 fixed in two gates, found six more times: a loop over a glob that now matches nothing, reporting success. just test printed "All FFI tests passed!" over zero items. aspect_tests.sh Aspect 4 printed "All cartridges accounted for (0 complete, 0 stub, 0 ffi_only)". Both now fail on an empty set.

Changes

Item	What
Justfile	8 sites in 6 recipes now read CARTS="${BOJ_CARTRIDGES_PATH:-tests/fixtures/cartridges}", the convention tests/e2e_full.sh already set. test/test-verbose fail on an empty set; build/heal/tour say so out loud. clean targets the fixture only — deliberately not the operator's fetched cache. 108 recipes still parse.
scripts/refresh-bundled-cartridges.sh	Deleted — it existed solely to sync the retired tree, and rm -rf'd inside it. No references anywhere.
scripts/boj-selinux-contexts.sh	Was labelling <repo>/cartridges/. Repointed at the cache root, and skips with a message when no cache exists rather than labelling an impossible path.
generate-offline-menu.js	Its fallback was the deleted tree, so with no env var it silently regenerated an empty menu. Now falls back to the fixture and exit(1)s on an empty root.
aspect_tests.sh, integration.sh, federation_multinode.sh	Repointed. integration.sh step 5's bare cd under set -e was killing the run outright.
SECURITY.md	The vulnerability template sent reporters to cartridges/browser-mcp/ and cartridges/cloudflare/ — the latter was never even a real directory name.
Gitlinks	Two .claude/worktrees entries were committed as mode-160000 with no .gitmodules, so a fresh clone got two empty dirs and both showed permanently modified. git rm --cached + .gitignore. Directories on disk untouched.

One judgement call worth surfacing: the fixture manifests use catalogued/ready where aspect_tests.sh expects stub/ffi_only, so a naive repoint produced 23 spurious failures. Rather than loosen the check, all 23 manifests were verified to confirm catalogued ≡ manifest-only and ready ≡ ffi-without-abi — the two rules that already existed — and the synonyms documented. Likewise integration.sh skips manifest-only cartridges rather than failing them: reporting "missing adapter" against a catalogue that is manifest-only by design would be a fabricated defect in the other direction.

Verification

check	result
just --list	108 recipes parse
bash tests/aspect_tests.sh	exit 0 — 43 passed, 0 failed; Aspect 4 names the root and 23 items
same, with an empty BOJ_CARTRIDGES_PATH	exit 1 — "completeness verified nothing"
workflows YAML	25 parse
node --check + deno check	clean
shellcheck -S error, all touched scripts	clean

Build residue — reported, not touched

1,346 files / 226 .so / 4.3 GB survive under cartridges/ on disk, invisible to git status (gitignored). Investigated rather than assumed:

• Nothing has touched it in three weeks — newest mtime 2026-07-17, retirement commit 2026-08-04. Zero cartridge.json, zero .zig sources: it is purely build output.
• The local-coord-mcp.service unit does not exist on this machine, user or system.
• No live process maps any .so under cartridges/ (/proc/*/maps is clean).

Deletion looks safe, but it is disk state outside git — your call, so nothing was removed.

Found en route, deliberately out of scope

container/Containerfile.fly:80 does COPY cartridges/ /tmp/carts-meta/ from the host build context and never runs fetch-cartridges.sh — COPY on a missing source is a hard failure, so that image cannot build. Note the main container/Containerfile is fine: it fetches into the builder stage first, so its COPY --from=zig-builder /build/cartridges/ is populated. One file, not both.

Also stale and untouched: stapeln.toml:44 (same empty-loop class, plus || true so it can never fail), coord-tui/install.sh:28, guix.scm:34, elixir/test/js_worker_pool_test.exs:6 (two tests currently pass by short-circuiting when Deno is absent), and dead entries in .hypatia-ignore / .gitleaksignore / .dockerignore. These are logged rather than swept so each gets a reviewable change.

🤖 Generated with Claude Code

[gitar-bot]

Note

Automatic reviews are paused because your trial's included automatic processing has been used for this period. Upgrade now, or comment "Gitar review" to run a review anytime.
Learn more

Code Review ✅ Approved 1 resolved / 1 findings

Finishes the cartridges directory retirement by repointing recipes, tests, and scripts to the active catalog root and preventing empty-set silent successes. Consider harmonizing the global SKIP counter increments between Step 4 and Step 7 in the test scripts.

Auto-approved and auto-merge armed: No blocking issues found.
Please see Auto-approve Docs for details on setting custom approval criteria. — merges when pipeline and required approvals pass.

✅ 1 resolved

✅ Quality: SKIP tally inconsistent between Step 4 and Step 7

📄 tests/integration.sh:104-118 📄 tests/integration.sh:173-187
In Step 4 the per-cartridge skips only bump the local adapter_skipped, and the global SKIP counter is incremented just once at the end regardless of how many subjects were skipped, whereas Step 7's matrix loop increments the global SKIP once per skipped cartridge. The summary's skipped figure therefore under-counts Step 4 skips. It does not affect the exit code (driven by FAIL), so this is cosmetic; align Step 4 to increment SKIP per skipped cartridge for an accurate tally.

Options

Display: compact → Showing less information.

Comment with these commands to change the behavior for this request:

Compact

gitar display:verbose

---

Important

Your trial ends in 3 days — upgrade now to keep code review, CI analysis, auto-apply, custom automations, and more.

_{Was this helpful? React with 👍 / 👎 | Gitar}

[gitar-bot]

Gitar has auto-approved this PR and enabled auto-merge (configure)

✅ All code review findings resolved.

_{Configure merge blocking}